| Summary: | String::Random is marked as optional, but C4::Members requires it | ||
|---|---|---|---|
| Product: | Koha | Reporter: | MJ Ray (software.coop) <mjr> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | MJ Ray (software.coop) <mjr> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | normal | ||
| Priority: | P2 | CC: | jonathan.druart, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 9734 - String::Random is marked as optional, but C4::Members requires it
Bug 9734 - String::Random is marked as optional, but C4::Members requires it Bug 9734 - String::Random is marked as optional, but C4::Members requires it Bug 9734 - String::Random is marked as optional, but C4::Members requires it |
||
|
Description
MJ Ray (software.coop)
2013-02-28 15:44:01 UTC
Created attachment 15776 [details] [review] Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the "No" in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. Sponsored-by: software.coop Created attachment 15777 [details] [review] Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the "No" in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. 4) prove t/Installer_PerlModules.t # which checks String::Random is required Sponsored-by: software.coop Created attachment 15804 [details] [review] Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the "No" in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. 4) prove t/Installer_PerlModules.t # which checks String::Random is required Sponsored-by: software.coop Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA comment: Maybe it would be easy not to use this dependency and implement a simple routine to do the same thing (in order to avoid an additional dependency). But that's not really the question here. This patch marks the String::Random module as mandatory. Marked as Passed QA. Created attachment 15972 [details] [review] Bug 9734 - String::Random is marked as optional, but C4::Members requires it jcamins confirmed on IRC it is not optional. To test: 1) perl koha_perl_deps.pl -a |grep String::Random 2) notice the "No" in the last column - it should be Yes 3) apply patch and repeat same steps, looking for Yes. 4) prove t/Installer_PerlModules.t # which checks String::Random is required Sponsored-by: software.coop Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. |