| Summary: | noitemlinks not being enforced | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Self checkout | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9748 - noitemlinks not being enforced
Bug 9748: don't link items in SCO checkout list back to main OPAC Bug 9748: don't link items in SCO checkout list back to main OPAC |
||
|
Description
Kyle M Hall (khall)
2013-03-05 19:07:35 UTC
Created attachment 15895 [details] [review] Bug 9748 - noitemlinks not being enforced It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links Created attachment 16085 [details] [review] Bug 9748: don't link items in SCO checkout list back to main OPAC It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links Signed-off-by: Galen Charlton <gmc@esilibrary.com> QA comment: I don't understand why links are hidden and how they can be shown (when noitemlinks is false?), but it was the excepted behavior before the conversion to TT. Marked as Passed QA. Created attachment 16405 [details] [review] Bug 9748: don't link items in SCO checkout list back to main OPAC It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored. This is a problem for SCO kiosks where all the navigation controls are hidden. Clicking the link means leaving the SCO module and not being able to get back. Test plan: 1) Run SCO module, check for item links 2) Apply patch 3) Run SCO module, note that the items no longer have links Signed-off-by: Galen Charlton <gmc@esilibrary.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 |