Summary: | Patron flags red in moremember.pl like in circulation.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Patrons | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
screen-shot with patch Bug 9751: Patron flags red in moremember.pl like in circulation.pl Check out tab for a patron with flags set Details tab for a patron with flags set [PASSED QA] Bug 9751: Patron flags red in moremember.pl like in circulation.pl |
Description
Fridolin Somers
2013-03-06 10:20:55 UTC
Created attachment 15903 [details] [review] Proposed patch See commit comment Created attachment 15904 [details]
screen-shot with patch
Created attachment 15986 [details] [review] Bug 9751: Patron flags red in moremember.pl like in circulation.pl In a patron detail page (moremember.pl), when looking at a patron with one or more flags. Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian. This patch add CSS classes to patron flags in moremember.pl so they look more like circulation.pl : - red color - custom list bullets Test plan ; - Set to a patron all flags. - Go to detail page of this patron => Check all flags are red and bullets are like ">" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 16494 [details]
Check out tab for a patron with flags set
Created attachment 16495 [details]
Details tab for a patron with flags set
The patch is an improvement, as it makes the flags display more consistent, but there are still some differences I wanted to show with those 2 screenshots.
Passing QA on this as it is an improvement :)
Created attachment 16496 [details] [review] [PASSED QA] Bug 9751: Patron flags red in moremember.pl like in circulation.pl In a patron detail page (moremember.pl), when looking at a patron with one or more flags. Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian. This patch add CSS classes to patron flags in moremember.pl so they look more like circulation.pl : - red color - custom list bullets Test plan ; - Set to a patron all flags. - Go to detail page of this patron => Check all flags are red and bullets are like ">" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch makes display more consistent and passes all tests. This patch has been pushed to master. |