Summary: | Replace YUI buttons on the authority search popup with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | bgkriegel, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/authorities/auth_finder.pl | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 9779 | ||
Attachments: |
Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap
[SIGNED-OFF] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap [PASSED QA] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap |
Description
Owen Leonard
2013-03-07 19:20:30 UTC
Created attachment 15953 [details] [review] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the <script> tag in order to eliminate undesirable javascript: pseudo-protocol links. To test, open a bibliographic record for editing and click the authority edit link next to a field with authority-linked data in it. - Confirm that buttons in the popup window look correct. - Confirm that the "Clear field" button clears the field in the MARC editor. - Confirm that the "Create new authority" button launches a blank authority editor. Created attachment 15958 [details] [review] [SIGNED-OFF] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the <script> tag in order to eliminate undesirable javascript: pseudo-protocol links. To test, open a bibliographic record for editing and click the authority edit link next to a field with authority-linked data in it. - Confirm that buttons in the popup window look correct. - Confirm that the "Clear field" button clears the field in the MARC editor. - Confirm that the "Create new authority" button launches a blank authority editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. All buttons works: look correct, clear works, create works. Created attachment 16583 [details] [review] [PASSED QA] Bug 9764 - Replace YUI buttons on authority search popup with Bootstrap The authority search popup styles several buttons with YUI. Bootstrap should be used instead. This patch removes YUI styling from two buttons ("Submit" and "Cancel") in favor of default styling for consistency's sake. The other buttons ("Clear field" and "Create new") have been moved to a standard toolbar div and styled with Bootstrap. Some inline JavaScript has been moved to the <script> tag in order to eliminate undesirable javascript: pseudo-protocol links. To test, open a bibliographic record for editing and click the authority edit link next to a field with authority-linked data in it. - Confirm that buttons in the popup window look correct. - Confirm that the "Clear field" button clears the field in the MARC editor. - Confirm that the "Create new authority" button launches a blank authority editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. All buttons works: look correct, clear works, create works. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done according to test plan. http://bugs.koha-community.org/show_bug.cgi?id=9765 This patch has been pushed to master. |