| Summary: | Problem with grace period calculation and fine intervals >1 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Bug 4906 was originally meant for this problem, but went into another direction. Hopefully, Katrin still wants to look at this.. QA Comment: Kyle probably should have opened a new report for this development some time ago. I did now the other way around. Bug 9768 is the new old one :) This patch works as advertised. Code looks good to me. Passed QA (In reply to comment #2) > QA Comment: > Kyle probably should have opened a new report for this development some time > ago. I did now the other way around. Bug 9768 is the new old one :) > > This patch works as advertised. Code looks good to me. > > Passed QA Yeah.. This should have been a comment at the other report.. We are still very interested in seeing this fixed - until a new report is filed, I'd like to remove the WONTFIX. |
With a fine interval > 1 there is currently no way to avoid a effective grace period. Fines can not start the day after the due date. Configuration: With grace period = 1 fine interval 5 (= weekly, the library is closed Sunday and Saturday) Result: The first fine ist set 7 days after the item was due. Monday, checkout Tuesday, item due Wednesday Thursday Friday Saturday, holiday Sunday, holiday Monday, Tuesday, first fine Grace period for fine intervals > 1 should describe the days between the due date and the day the first fine is set. CalcFines() in Overdues.pm: 266 my $days_minus_grace = $daystocharge - $data->{'firstremind'}; 267 if ($data->{'chargeperiod'} > 0 && $days_minus_grace > 0 ) { 268 $amount = int($daystocharge / $data->{'chargeperiod'}) * $data->{'fine'};