Summary: | Replace YUI buttons on acquisitions basket page with Bootstrap | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | brendan, katrin.fischer, mathsabypro |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/basket.pl?basketno= | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 9779 | ||
Attachments: |
Bug 9769 - Replace YUI buttons on acquisitions basket page with Bootstrap
Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap [PASSED QA] Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR |
Description
Owen Leonard
2013-03-08 14:45:43 UTC
Created attachment 15976 [details] [review] Bug 9769 - Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export I cannot reopen a closed basket. All the rest is correct. M. Saby Created attachment 16240 [details] [review] Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export Revision corrects check for 'skip_confirm_reopen' variable when reopening baskets. Please test with BasketConfirmations both on and off. Created attachment 16269 [details] [review] Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export Revision corrects check for 'skip_confirm_reopen' variable when reopening baskets. Please test with BasketConfirmations both on and off. Signed-off-by: Brendan <brendan@bywatersolutions.com> Followed test plan and this worked. Created attachment 16573 [details] [review] [PASSED QA] Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export Revision corrects check for 'skip_confirm_reopen' variable when reopening baskets. Please test with BasketConfirmations both on and off. Signed-off-by: Brendan <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested all options, some notes about behaviour: - closing a basket is only possible, when there are no uncertain prices (no button close basket) - reopening a basket requires, that you first remove the basket from any basket group (no button to reopen basket) This patch has been pushed to master. Created attachment 18068 [details] [review] [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All test passed Comment on attachment 18068 [details] [review] [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR wrong bug |