Description
Owen Leonard
2013-03-08 15:36:48 UTC
Created attachment 15984 [details] [review] Bug 9771 - Replace YUI buttons on acquisitions basket groups page with Bootstrap The acquisitions basket group page has a toolbar with YUI-generated buttons and menus. It should use Bootstrap instead. This patch removes the YUI menu buttons altogether, replacing that functionality with the sidebar menu now included on other acquisitions pages (See Bug 8913). The "New basket group" button is now styled by Bootstrap. Other minor changes: Corrections of invalid markup, improvement to breadcrumbs. To test, view the basket group page and confirm that the toolbar button looks correct and works correctly. Confirm that navigation works and that functionality of the basket group edit page is not affected. It works like before, but the 2 big blocks are getting larger. I prefer smaller blocks, but maybe you won't agree? I join a screenshot. M. Saby Rennes 2 university Created attachment 15995 [details]
screenshot
Created attachment 16005 [details] [review] Bug 9771 [Revised] Replace YUI buttons on acquisitions basket groups page with Bootstrap The acquisitions basket group page has a toolbar with YUI-generated buttons and menus. It should use Bootstrap instead. This patch removes the YUI menu buttons altogether, replacing that functionality with the sidebar menu now included on other acquisitions pages (See Bug 8913). The "New basket group" button is now styled by Bootstrap. Other minor changes: Corrections of invalid markup, improvement to breadcrumbs. To test, view the basket group page and confirm that the toolbar button looks correct and works correctly. Confirm that navigation works and that functionality of the basket group edit page is not affected. Revision adds an explicit width to the basket-grouping form columns so that they don't stretch too wide (and far from each other) when the browser window is very wide. This better replicates the layout of the previous version. Created attachment 16006 [details] [review] [PATCH] [SIGNED-OFF] Bug 9771 [Revised] Replace YUI buttons on acquisitions basket groups page with Bootstrap Thank you. Everything OK for me, I sign off. M. Saby Created attachment 16595 [details] [review] [PASSED QA] Bug 9771 [Revised] Replace YUI buttons on acquisitions basket groups page with Bootstrap The acquisitions basket group page has a toolbar with YUI-generated buttons and menus. It should use Bootstrap instead. This patch removes the YUI menu buttons altogether, replacing that functionality with the sidebar menu now included on other acquisitions pages (See Bug 8913). The "New basket group" button is now styled by Bootstrap. Other minor changes: Corrections of invalid markup, improvement to breadcrumbs. To test, view the basket group page and confirm that the toolbar button looks correct and works correctly. Confirm that navigation works and that functionality of the basket group edit page is not affected. Revision adds an explicit width to the basket-grouping form columns so that they don't stretch too wide (and far from each other) when the browser window is very wide. This better replicates the layout of the previous version. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script happy. This patch has been pushed to master. |