Bug 9772

Summary:	Displayed Norwegian chars correctly in the patron category dropdown on the Patrons page
Product:	Koha	Reporter:	Magnus Enger <magnus>
Component:	Patrons	Assignee:	Magnus Enger <magnus>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	normal
Priority:	P5 - low	CC:	chris, gmcharlt, kyle.m.hall
Version:	Main
Hardware:	All
OS:	All
See Also:	http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 9772 - Display Norwegian chars correctly in the patron category dropdown [SIGNED-OFF] Bug 9772 - Display Norwegian chars correctly in the patron category dropdown [PASSED QA] Patch

Description Magnus Enger 2013-03-08 16:08:46 UTC

If you install the Norwegian sample data (specifically the sample patron categories) and go to the Patrons page, then click on the patron category dropdown to create a new patron, the Norwegian characters are displayed as black diamonds with a question mark in them. 

As far as I can tell, the sample data should be OK, and when they are displayed in Administration > Patron categories, they do look ok.

Comment 1 Magnus Enger 2013-03-08 16:17:13 UTC Comment hidden (obsolete)

Created attachment 15987 [details] [review]
Bug 9772 - Display Norwegian chars correctly in the patron category dropdown

To reproduce:
- Install Norwegian translation
- Run through the web installer in Norwegian, and make sure you choose
  the optionl ("2-Valgfritt") patron_categories.sql data
- Log in and visit the "Patrons" page
- The dropdown should contain black diamonds with question marks instead
  of the Norwegian chars æøå

To test
- Apply the patch to the situation above
- Check the dropdown again - æøå should be displayed
- If you want to check with other interface languages than Norwegian,
  remember to re-install the nb-NO translation after the patch has been
  applied

This feels slightly like curing the symptom instead of the disease,
alternative patches are welcome!

Comment 2 Owen Leonard 2013-03-11 18:32:05 UTC Comment hidden (obsolete)

Created attachment 16049 [details] [review]
[SIGNED-OFF] Bug 9772 - Display Norwegian chars correctly in the patron category dropdown

To reproduce:
- Install Norwegian translation
- Run through the web installer in Norwegian, and make sure you choose
  the optionl ("2-Valgfritt") patron_categories.sql data
- Log in and visit the "Patrons" page
- The dropdown should contain black diamonds with question marks instead
  of the Norwegian chars æøå

To test
- Apply the patch to the situation above
- Check the dropdown again - æøå should be displayed
- If you want to check with other interface languages than Norwegian,
  remember to re-install the nb-NO translation after the patch has been
  applied

This feels slightly like curing the symptom instead of the disease,
alternative patches are welcome!

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I agree that this doesn't seem like a broad enough solution, but it
doesn't do any harm to apply an incomplete fix as long as the underlying
problem can be followed up on. Note that this problem isn't specific to
Norwegian, but doesn't happen with all non-basic characters.

Comment 3 Katrin Fischer 2013-03-20 10:54:02 UTC

Created attachment 16490 [details] [review]
[PASSED QA] Patch

Attaching patch in "the traditional way" as git bz was unhappy with the non latin characters in the commit message.

Comment 4 Jared Camins-Esakov 2013-03-20 12:03:15 UTC

This patch has been pushed to master.

Comment 5 Chris Cormack 2013-04-03 19:27:51 UTC

Doesn't apply to 3.10.x please rebase and resubmit if you wish it to be in 3.10.x