| Summary: | [3.6.X/3.8.x] Fix dynarch calendar positioning in IE | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Templates | Assignee: | David Cook <dcook> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, m.de.rooy |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE
[SIGNED-OFF] Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE |
||
|
Description
David Cook
2013-03-10 23:44:24 UTC
Created attachment 16007 [details] [review] Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE Currently, if you click on the calendar icon on a long patron entry/edit page, the calendar pop-up appears off-screen near the top of the page rather than under the appropriate input box next to the actual icon. For most people, they don't think the calendar pop-up is actually created. For others, it's quite annoying to scroll up to the top of the page to pick a date for a date field lower on the page. -- I've adapted a patch I found at the following URL: http://blog.anorakgirl.co.uk/2009/04/dynarch-dhtml-calendar-ie7-positioning-problem/ This takes care of the problem. -- Test Plan: Before applying patch... 1) In any version of IE, create or edit a Patron entry 2) If you have a Date of birth field at the top, click the calendar icon next to it. 3) Note that the calendar pop-up appears fine. 4) Scroll down to the bottom of the page and click on the calendar icon next to Registration date or Expiry date. 5) Note that no calendar pop-up appears on the screen. Scroll up the page and you should see it up near the top of the page. Apply patch 6) Refresh the page (you might need to clear your cache as well) and try clicking the calendar icon next to Registration date or Expiry date 7) Note that the calendar pop-up appears correctly underneath the input box for which you want to pick a date Created attachment 16024 [details] [review] [SIGNED-OFF] Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE Currently, if you click on the calendar icon on a long patron entry/edit page, the calendar pop-up appears off-screen near the top of the page rather than under the appropriate input box next to the actual icon. For most people, they don't think the calendar pop-up is actually created. For others, it's quite annoying to scroll up to the top of the page to pick a date for a date field lower on the page. -- I've adapted a patch I found at the following URL: http://blog.anorakgirl.co.uk/2009/04/dynarch-dhtml-calendar-ie7-positioning-problem/ This takes care of the problem. -- Test Plan: Before applying patch... 1) In any version of IE, create or edit a Patron entry 2) If you have a Date of birth field at the top, click the calendar icon next to it. 3) Note that the calendar pop-up appears fine. 4) Scroll down to the bottom of the page and click on the calendar icon next to Registration date or Expiry date. 5) Note that no calendar pop-up appears on the screen. Scroll up the page and you should see it up near the top of the page. Apply patch 6) Refresh the page (you might need to clear your cache as well) and try clicking the calendar icon next to Registration date or Expiry date 7) Note that the calendar pop-up appears correctly underneath the input box for which you want to pick a date Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully using IE9 on Windows 7. This bug affects 3.6.x too, and the patch applies there as well. QA Comment: Looks good to me. Trivial change. Not tested :) Sure that this comes up from IE7 onward ? Changing status. Please attract the attention of 3.6.x/3.8.x RMaints yourself. Thanks. Would not use staff client in IE BTW :) (In reply to comment #5) > Would not use staff client in IE BTW :) It's ok in IE9 onwards, but yeah, using the web with IE is just a bad idea :) Pushed to 3.8.x, over to you now Liz |