Bug 9782

Summary:	Cancel button doesn't work when importing MARC bibliographic frameworks
Product:	Koha	Reporter:	David Cook <dcook>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:
Severity:	trivial
Priority:	P5 - low	CC:	gmcharlt
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks [PASSED QA] Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks

Description David Cook 2013-03-11 02:57:46 UTC

Currently, when importing a MARC bibliographic framework, you'll get a little animated loading gif and some text saying "Importing into...", as well as a link that says Cancel. I think this is the same Cancel link that is meant to close the pop-up, but it seems like you could use it to Cancel the import.

Well, if you click Cancel, the framework is still imported and now the "Importing into" pop-up remains on the page indefinitely regardless of how much you press Cancel. 

--

I suggest that we remove the Cancel link once the import has begun so as not to mislead users and so that the situation of the indefinite loading box doesn't occur.

Comment 1 Owen Leonard 2013-08-14 20:10:50 UTC Comment hidden (obsolete)

Created attachment 20355 [details] [review]
Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks

When importing frameworks the "cancel" button should be hidden once an
import is initiated since it is not possible to cancel the import in
progress.

This patch uses this bug as an excuse to replace the old import/export
pop-ups with modal dialogs for all import/export functions.

To test:

- Try exporting both the default framework and at least one other
  framework.
- Try importing both a default framework and at least one other
  framework.
- When importing, observe that the modal dialog controls are hidden as
  soon as the import is initiated.

Comment 2 David Cook 2013-08-21 07:40:21 UTC Comment hidden (obsolete)

Created attachment 20522 [details] [review]
Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks

When importing frameworks the "cancel" button should be hidden once an
import is initiated since it is not possible to cancel the import in
progress.

This patch uses this bug as an excuse to replace the old import/export
pop-ups with modal dialogs for all import/export functions.

To test:

- Try exporting both the default framework and at least one other
  framework.
- Try importing both a default framework and at least one other
  framework.
- When importing, observe that the modal dialog controls are hidden as
  soon as the import is initiated.

Signed-off-by: David Cook <dcook@prosentient.com.au>

Comment 3 Katrin Fischer 2013-08-25 20:40:11 UTC

Created attachment 20607 [details] [review]
[PASSED QA] Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks

When importing frameworks the "cancel" button should be hidden once an
import is initiated since it is not possible to cancel the import in
progress.

This patch uses this bug as an excuse to replace the old import/export
pop-ups with modal dialogs for all import/export functions.

To test:

- Try exporting both the default framework and at least one other
  framework.
- Try importing both a default framework and at least one other
  framework.
- When importing, observe that the modal dialog controls are hidden as
  soon as the import is initiated.

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, passes all tests and QA script.
Also the modal works better on smaller screens.

Comment 4 Galen Charlton 2013-08-28 15:44:47 UTC

Pushed to master.  Thanks, Owen!