|
Description
Marcel de Rooy
2013-03-18 10:42:20 UTC
The itemnumber is kept as a 'better safe than sorry' approach. That is, it is better to make sure the patron gets exactly the item they wanted rather than risk giving the patron an item he or she didn't want. I think the solution is to just add a new field 'hold_level' to the reserves table that is marked as 'bib' or 'item' when a reserve is first placed. That way we can know at the time of reversion if we need to remove the itemnumber or not. My feeling is that if it started as an "any available" it should go back to that. But yea, we'd have to know if it was placed that way in order to put it back. Practically, the current way might mean that a borrower waits an extra circ period for their reserve, which is bad service by the library. Liz Still valid? Still valid. Being able to revert an item level hold to a global hold would be excellent. We only allow patrons to make global holds, so patrons waiting for specific items (which are now on loan) when they could've had one of the other copies is not ideal. It also impacts the patron who checked out the item, as they have to return it after one circ period, and cannot renew. Definitely needed for all the reasons mentioned: if holds are 'next available' (which is nearly always the case for us) then turning it into an item-level hold on allocation isn't ideal. Also, usually if you're reverting the waiting status it's because the item has gone missing, so the only way to fix this is actually to cancel the hold and then place a new hold and push the borrower to the top of the list again, which is ...suboptimal. This is still valid in 18.11.05. Created attachment 90397 [details] [review] Bug 9834: Add DB changes Created attachment 90398 [details] [review] Bug 9834: Add tests Created attachment 90399 [details] [review] Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") Created attachment 90436 [details] [review] Bug 9834: Add DB changes Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 90437 [details] [review] Bug 9834: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 90438 [details] [review] Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 90611 [details] [review] Bug 9834: Add DB changes Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 90612 [details] [review] Bug 9834: Add tests Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 90613 [details] [review] Bug 9834: Preserve biblio level hold preference on reverting waiting status When the waiting status of a hold is revert we want to preserve the level hold preference of the user. Test plan: Place a hold at biblio level Confirm the hold Revert the waiting hold => The hold must still be considered as a biblio level hold ("next available item") Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 Comment on attachment 90611 [details] [review] Bug 9834: Add DB changes >+ `item_level_hold` BOOLEAN NOT NULL DEFAULT 0, -- Is the hpld placed at item level Please see https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans This is missing a tweak to hold.json and to the schema files. Created attachment 90677 [details] [review] Bug 9834: (QA follow-up) API fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (In reply to Tomás Cohen Arazi from comment #17) > Comment on attachment 90611 [details] [review] [review] > Bug 9834: Add DB changes > > >+ `item_level_hold` BOOLEAN NOT NULL DEFAULT 0, -- Is the hpld placed at item level > > Please see > https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans > > This is missing a tweak to hold.json and to the schema files. How do we catch the next ones? Pushed followup to master I assume this breaks upgrading the Koha DB schema at DB revision 16.12.00.032
>[…]
>Upgrade to 16.12.00.030 done (Bug 16344 - Add a circ rule to limit the auto renewals given a specific date)
>Upgrade to 16.12.00.031 done (Bug 15108: OAI-PMH provider improvements)
>DBD::mysql::st execute failed: Unknown column 'me.item_level_hold' in 'field list' [for Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`, `me`.`item_level_hold` FROM `reserves` `me` WHERE ( ( `found` = ? AND `priority` = ? ) )" with ParamValues: 0='W', 1=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
>DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.item_level_hold' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 209
(In reply to Mirko Tietgen from comment #21) > I assume this breaks upgrading the Koha DB schema at DB revision 16.12.00.032 > > >[…] > >Upgrade to 16.12.00.030 done (Bug 16344 - Add a circ rule to limit the auto renewals given a specific date) > >Upgrade to 16.12.00.031 done (Bug 15108: OAI-PMH provider improvements) > >DBD::mysql::st execute failed: Unknown column 'me.item_level_hold' in 'field list' [for Statement "SELECT `me`.`reserve_id`, `me`.`borrowernumber`, `me`.`reservedate`, `me`.`biblionumber`, `me`.`branchcode`, `me`.`notificationdate`, `me`.`reminderdate`, `me`.`cancellationdate`, `me`.`reservenotes`, `me`.`priority`, `me`.`found`, `me`.`timestamp`, `me`.`itemnumber`, `me`.`waitingdate`, `me`.`expirationdate`, `me`.`lowestPriority`, `me`.`suspend`, `me`.`suspend_until`, `me`.`itemtype`, `me`.`item_level_hold` FROM `reserves` `me` WHERE ( ( `found` = ? AND `priority` = ? ) )" with ParamValues: 0='W', 1=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > >DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.item_level_hold' in 'field list' at /usr/share/koha/lib/Koha/Objects.pm line 209 Filed a new bug for this: bug 23267 *** Bug 15679 has been marked as a duplicate of this bug. *** |