Summary: | Use DataTables on suggestions management page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, paul.poulain |
Version: | 3.12 | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/suggestion/suggestion.pl | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9879 - Use DataTables on suggestions management page
Bug 9879 - Use DataTables on suggestions management page Bug 9879 - Use DataTables on suggestions management page |
Description
Owen Leonard
2013-03-20 19:41:30 UTC
Created attachment 16558 [details] [review] Bug 9879 - Use DataTables on suggestions management page Replace the tablesorter plugin with the DataTables plugin on the suggestions management page. Table sorting has been coverted from using multiple specific IDs to a more efficient class-based selector. Unrelated change: Prevent page-jumping when checkbox links are clicked. To test, open the suggestions management page (Acquisitions -> Suggestions). Confirm that table sorting, paging, and searching works correctly. I will accept this for 3.12, since it is fixing the general bug "Koha still uses tablesorter." Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr> Created attachment 16572 [details] [review] Bug 9879 - Use DataTables on suggestions management page Replace the tablesorter plugin with the DataTables plugin on the suggestions management page. Table sorting has been coverted from using multiple specific IDs to a more efficient class-based selector. Unrelated change: Prevent page-jumping when checkbox links are clicked. To test, open the suggestions management page (Acquisitions -> Suggestions). Confirm that table sorting, paging, and searching works correctly. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr> QA comment: This patch replaces tablesorter with Datatable on the suggestions management page. Owen uses "e.preventDefault()" where I would use "return false;", but it does the same job! Marked as Passed QA. Created attachment 16668 [details] [review] Bug 9879 - Use DataTables on suggestions management page This patch has been pushed to master. |