Summary: | Remove unused tablesorter plugin from offline circulation page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/offline_circ/list.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9881 - Remove unused tablesorter plugin from offline circulation page
Bug 9881 - Remove unused tablesorter plugin from offline circulation page [PASSED QA] Bug 9881 - Remove unused tablesorter plugin from offline circulation page |
Description
Owen Leonard
2013-03-21 00:46:55 UTC
Created attachment 16563 [details] [review] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Created attachment 16564 [details] [review] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 16912 [details] [review] [PASSED QA] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> One line change, followed test plan, no negative consequences found. This patch has been pushed to master. |