| Summary: | export_borrowers.pl separator should default to the 'delimiter' syspref value | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
| Component: | Command-line Utilities | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bgkriegel, jonathan.druart, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 14215 | ||
| Attachments: |
Bug 9892: MAke export_borrowers.pl using the delimiter pref
[SIGNED-OFF] Bug 9892: Make export_borrowers.pl using the delimiter pref Bug 9892: Make export_borrowers.pl using the delimiter pref Bug 9892: [QA Follow-up] Typo and updated usage Bug 9892: Make export_borrowers.pl using the delimiter pref Bug 9892: [QA Follow-up] Typo and updated usage |
||
|
Description
Jared Camins-Esakov
2013-03-21 14:45:44 UTC
Kyle noted a possibility in his comments on bug 9045: ./export_borrowers.pl -w "borrowernumber > 30" -s $'\t' This seems to do the trick, but is probably a bit hard to guess. Maybe we should add it to the documentation or provide an easier way in the script? In other scripts we parse \t. Created attachment 37619 [details] [review] Bug 9892: MAke export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Created attachment 38895 [details] [review] [SIGNED-OFF] Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors Created attachment 38967 [details] [review] Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors Created attachment 38968 [details] [review] Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 38969 [details] [review] Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 38970 [details] [review] Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> QA Comment: The problem in Comment1 has not yet been fully addressed. You can now choose tabulation in the delimiter pref but it is hard to pass a tab via the command line. But it is an improvement imo. The commit message says: [This should be highlighted on the release, it can produce change in behaviors.] This only pertains to the situation that someone does not pass a separator parameter and has a delimiter<>comma. Patches pushed to master. Thanks Jonathan! |