|
Description
Katrin Fischer
2013-03-22 10:31:49 UTC
On the subscription view there is a little typo in the acquisition section: 'See invoice informations' should be 'information' fund should be Fund (column name) This is still relevant as of the current master (e330b69). It's easy to fix, so I'll submit a patch soon. (In reply to Katrin Fischer from comment #1) > On the subscription view there is a little typo in the acquisition section: > 'See invoice informations' should be 'information' > fund should be Fund (column name) I can't seem to find these typos, presumably they got fixed? Created attachment 55539 [details] [review] Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Created attachment 55622 [details] [review] Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Followed test plan, works as expected. Signed-off-by: Marc <veron@veron.ch> Created attachment 55624 [details] [review] Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 55641 [details] [review] [PASSED QA] Bug 9896 - Show vendor in subscription search when creating an order for a subscription In the staff client, when creating an order from a subscription the vendor name should be shown in a separate column. This patch adds that feature. The 'Vendor' column is added before the 'Library' column since they appear in that order in Advanced search. Test plan: 0) [PREREQUISITES] In the Staff client, under Acquisitions, create a Vendor and associated Basket if you don't already have them. Then, under Serials, add a new Subscription using the Vendor you've just created. 1) Go to Acquisitions, and under 'Manage orders' search for a vendor, then click on 'Add to basket' and select 'From a subscription'. 2) Click 'Search' on the left hand side to search for all subscriptions. Notice how there is no 'Vendor' column in the results table. 3) Apply the patch. 4) Repeat step 2. Confirm that the patch works, i.e. there is now a 'Vendor' column which displays the vendor name. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11, thanks Andreas! Pushed in 16.05. Will be in 16.05.05. |