| Summary: | Sort by date broken on patron detail page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle.m.hall |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /members/moremember.pl?borrowernumber=X | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 9887 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 9903 - Sort by date broken on patron detail page
Bug 9903 - Sort by date broken on patron detail page [PASSED QA] Bug 9903 - Sort by date broken on patron detail page Bug 9903: Followup: use the KohaDates T::T plugin to display dates. |
||
|
Description
Owen Leonard
2013-03-22 15:18:41 UTC
Created attachment 17308 [details] [review] Bug 9903 - Sort by date broken on patron detail page When the patron detail page switched to DataTables no accommodation was made for metric date formats in sorting. This patch adds sorting based on data in a span's title attribute, and thus requires that the patch for Bug 9887 be applied. To test, view the detail page for a patron who has assorted checkouts, relatives' checkouts, and holds. Sorting of date columns should be correct with the dateformat preference set to any value. After applying this patch, I can no longer sort holds on moremember.pl Created attachment 17405 [details] [review] Bug 9903 - Sort by date broken on patron detail page When the patron detail page switched to DataTables no accommodation was made for metric date formats in sorting. This patch adds sorting based on data in a span's title attribute, and thus requires that the patch for Bug 9887 be applied. To test, view the detail page for a patron who has assorted checkouts, relatives' checkouts, and holds. Sorting of date columns should be correct with the dateformat preference set to any value. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Owen, Isn't possible to use the KohaDates plugin and don't call output_pref in the perl script? It will avoid to pass new variables. (In order to have something like <span title="[% issueloo.date_due %]">[% issueloo.date_due | $KohaDates %]</span>) Created attachment 17627 [details] [review] [PASSED QA] Bug 9903 - Sort by date broken on patron detail page When the patron detail page switched to DataTables no accommodation was made for metric date formats in sorting. This patch adds sorting based on data in a span's title attribute, and thus requires that the patch for Bug 9887 be applied. To test, view the detail page for a patron who has assorted checkouts, relatives' checkouts, and holds. Sorting of date columns should be correct with the dateformat preference set to any value. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Nice improvement. Hi Owen, sorry, I see now that I missed Jonathans question in comment 4 when I looked at this, could you provide a follow up/new patch/feedback...? Created attachment 17643 [details] [review] Bug 9903: Followup: use the KohaDates T::T plugin to display dates. This patch has been pushed to master and 3.12.x. |