| Summary: | Link to plugins management should not be in global navigation | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, nengard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 9904 - Link to plugins management should not be in global navigation
Bug 9904 - Link to plugins management should not be in global navigation [PASSED QA] Bug 9904 - Link to plugins management should not be in global navigation |
||
|
Description
Owen Leonard
2013-03-22 15:29:57 UTC
Created attachment 16805 [details] [review] Bug 9904 - Link to plugins management should not be in global navigation With the addition of the Plugins feature a link was added to the global navigation in the "More" submenu. I think this is unnecessary. The global navigation should be limited to primary Koha functons. This patch removes the link. To test, apply the patch and confirm that there is no longer a link to Plugins in the header navigation under "More." Created attachment 17017 [details] [review] Bug 9904 - Link to plugins management should not be in global navigation With the addition of the Plugins feature a link was added to the global navigation in the "More" submenu. I think this is unnecessary. The global navigation should be limited to primary Koha functons. This patch removes the link. To test, apply the patch and confirm that there is no longer a link to Plugins in the header navigation under "More." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17045 [details] [review] [PASSED QA] Bug 9904 - Link to plugins management should not be in global navigation With the addition of the Plugins feature a link was added to the global navigation in the "More" submenu. I think this is unnecessary. The global navigation should be limited to primary Koha functons. This patch removes the link. To test, apply the patch and confirm that there is no longer a link to Plugins in the header navigation under "More." Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template patch, works as advertised. This patch has been pushed to master. I missed this originally, but I don't agree with this at all - it's a new module - how else do you get to the new module if it's not in the module menu? I also think this is a bad move. It's going to confuse, not clarify. Both the tool and report plugin links filter some of the plugins and aren't meant to be for full plugin management. I believe this commit should be reverted. (In reply to Kyle M Hall from comment #6) > I also think this is a bad move. It's going to confuse, not clarify. Both > the tool and report plugin links filter some of the plugins and aren't meant > to be for full plugin management. I believe this commit should be reverted. I won't be the one to revert it, and I'm setting the status accordingly. From the POV of an ordinary user, plugins are *not* a separate module -- they are simply a mechanism by which additional tools and reports can be made available. There really should be no separate plugins home page, just: - an admin page to upload and manage them - list of tool plugins (with "Home > Tools > Tool Plugins" as the breadcrumb list and the tools sidebar) - list of report plugins (with "Home > Reports > Report Plugins" as the breadcrumb list and the reports sidebar) The later two pages should *not* offer the upload link in the sidebar -- that is purely an administrative function. I'll file a separate bug for the above. |