Bug 9933

Summary: Changing/editing circulation rules for specific library affects all libraries
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact:
Severity: blocker    
Priority: P5 - low CC: chris, gmcharlt, kyle.m.hall, mirko, mtj
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9933: Unable to edit or add rules for any branch except default
Bug 9933: Unable to edit or add rules for any branch except default
Bug 9933: Unable to edit or add rules for any branch except default

Description Katrin Fischer 2013-03-27 06:07:04 UTC
I think we might be missing a parameter for the branch here - when editing or adding circulation rules for a specific library the change is made to all libraries instead. 
Also upon saving the screen switches to all libraries and does not stay on the selected specific library.
Comment 1 Chris Cormack 2013-04-08 08:28:09 UTC
I concur, I can recreate this bug, working on a fix now
Comment 2 Chris Cormack 2013-04-08 08:47:12 UTC Comment hidden (obsolete)
Comment 3 Mirko Tietgen 2013-04-08 10:04:48 UTC Comment hidden (obsolete)
Comment 4 Mason James 2013-04-08 10:10:05 UTC
Created attachment 17277 [details] [review]
Bug 9933: Unable to edit or add rules for any branch except default

To test
1/ Select a branch in circ rules
2/ Edit or add a rule, note this change is made for default instead of
the library you selected
3/ Apply the patch
4/ Try 1 and 2 again

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Works as expected.
Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 5 Mason James 2013-04-08 10:11:14 UTC
(In reply to comment #4)
> Created attachment 17277 [details] [review] [review]
> Bug 9933: Unable to edit or add rules for any branch except default
> 
> To test
> 1/ Select a branch in circ rules
> 2/ Edit or add a rule, note this change is made for default instead of
> the library you selected
> 3/ Apply the patch
> 4/ Try 1 and 2 again
> 
> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
> Works as expected.
> Signed-off-by: Mason James <mtj@kohaaloha.com>

works for me too, passing qa...
Comment 6 Jared Camins-Esakov 2013-04-15 12:32:03 UTC
This patch has been pushed to master and 3.12.x.