Bug 9937

Summary: Routines introduced for creating a subscription from an order need unit tests.
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: AcquisitionsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: normal    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 5343    
Bug Blocks:    
Attachments: Bug 9937: Add new unit tests for new routines (introduced by bug 5343)
Bug 9937: Add new unit tests for new routines (introduced by bug 5343)
[PASSED QA] Bug 9937: Add new unit tests for new routines (introduced by bug 5343)

Description Jonathan Druart 2013-03-27 14:12:13 UTC

    
Comment 1 Jonathan Druart 2013-03-27 14:17:34 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-03-29 09:31:52 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-30 20:20:03 UTC
Created attachment 17053 [details] [review]
[PASSED QA] Bug 9937: Add new unit tests for new routines (introduced by bug 5343)

New unit tests for 4 routines:
- C4::Serials::subscriptionCurrentlyOnOrder
- C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid
- C4::Acquisition::GetLastOrderReceivedFromSubscriptionid
- C4::Budgets::GetBudgetName

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed a tab in t/db/dependent/Budgets.t
All tests, new db_dependent tests and QA script pass. Thx Jonathan!
Comment 4 Jared Camins-Esakov 2013-03-30 21:05:59 UTC
This patch has been pushed to master.

I was unable to run the unit tests on my server due to database breakage, but Chris and Katrin report it working and today that's enough.