Summary: | Routines introduced for creating a subscription from an order need unit tests. | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 5343 | ||
Bug Blocks: | |||
Attachments: |
Bug 9937: Add new unit tests for new routines (introduced by bug 5343)
Bug 9937: Add new unit tests for new routines (introduced by bug 5343) [PASSED QA] Bug 9937: Add new unit tests for new routines (introduced by bug 5343) |
Description
Jonathan Druart
2013-03-27 14:12:13 UTC
Created attachment 16934 [details] [review] Bug 9937: Add new unit tests for new routines (introduced by bug 5343) New unit tests for 4 routines: - C4::Serials::subscriptionCurrentlyOnOrder - C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid - C4::Acquisition::GetLastOrderReceivedFromSubscriptionid - C4::Budgets::GetBudgetName Created attachment 17015 [details] [review] Bug 9937: Add new unit tests for new routines (introduced by bug 5343) New unit tests for 4 routines: - C4::Serials::subscriptionCurrentlyOnOrder - C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid - C4::Acquisition::GetLastOrderReceivedFromSubscriptionid - C4::Budgets::GetBudgetName Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17053 [details] [review] [PASSED QA] Bug 9937: Add new unit tests for new routines (introduced by bug 5343) New unit tests for 4 routines: - C4::Serials::subscriptionCurrentlyOnOrder - C4::Acquisition::GetLastOrderNotReceivedFromSubscriptionid - C4::Acquisition::GetLastOrderReceivedFromSubscriptionid - C4::Budgets::GetBudgetName Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed a tab in t/db/dependent/Budgets.t All tests, new db_dependent tests and QA script pass. Thx Jonathan! This patch has been pushed to master. I was unable to run the unit tests on my server due to database breakage, but Chris and Katrin report it working and today that's enough. |