| Summary: | MARC tab: tab 0 is not translated correctly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
| Component: | Templates | Assignee: | Adrien SAURAT <adrien.saurat> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, liz |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10049 | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
screenshot English
screenshot French proposed patch Bug 9953 - When OpacMaintenance brakes lifting debarment Bug 9952: translation of the "tab 0" in MARC detail [PASSED QA] Bug 9952: translation of the "tab 0" in MARC detail |
||
Created attachment 17022 [details]
screenshot French
Created attachment 17023 [details] [review] proposed patch TEST PLAN 1/ An install of Koha with at least two languages is needed. 2/ Select a biblio, go on the MARC detail page. 3/ In English, the first tab, 0, is displayed correctly. 4/ Switch to another language : without the patch, the 0 is not displayed. 5/ Apply patch. 6/ Translate the templates. 7/ Test again, the 0 should now be displayed in all languages. Created attachment 17039 [details] [review] Bug 9953 - When OpacMaintenance brakes lifting debarment When OpacMaintenance is on, any opac page will redirect to maintenance.pl. Some pages of intranet have the same behavior and you get 404 error. This is because in checkauth, if type arg is undefined it is "opac" by default. This patch adds type arg in all intranet calls of checkauth. Test plan : - Set syspref OpacMaintenance=Show - Go to a borrower page - Click on "Fines" and "Create manual invoice" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Click on "Fines" and "Create manual credit" - Enter an amount and save => Check you go to members/boraccount.pl and not maintenance.pl with 404 error OK - Edit borrower - Set "Restricted" to yes and save - Click on "Lift restriction" in messages => Check you keep in member page and not maintenance.pl with 404 error OK - Edit borrower - Set "Expiry date" to a day in the past and save - Click on "Renew" in messages => Check you keep in member page and not maintenance.pl with 404 error OK Signed-off-by: Liz Rea <liz@catalyst.net.nz> Good catch, a tricky bug. http://bugs.koha-community.org/show_bug.cgi?id=9952 Comment on attachment 17039 [details] [review] Bug 9953 - When OpacMaintenance brakes lifting debarment wrong bug. This patch fixes this problem, not sure how or why, but it does Before the patch, [% IF ( tab0XX ) %] <li><a href="#tab0XX"></a></li> After the patch [% IF ( tab0XX ) %] <li><a href="#tab0XX">0</a></li> Created attachment 17071 [details] [review] Bug 9952: translation of the "tab 0" in MARC detail The html code of 0 (0) is necessary for this tab to be correctly translated. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Not sure if this not only fixes the symptom instead of the bug. I guess we have this happening in other places as well. When you have reviews activated in the OPAC in German the tab always shows ( ) - in English it's (0). That said I am not opposed to a quick fix, but I would prefer finding out why it doesn't get parsed correctly by the translation scripts. Created attachment 17082 [details] [review] [PASSED QA] Bug 9952: translation of the "tab 0" in MARC detail The html code of 0 (0) is necessary for this tab to be correctly translated. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes display in translated templates. This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.5 |
Created attachment 17021 [details] screenshot English When displaying the MARC informations of a biblio, the numbered tabs are correctly displayed in Enlish but not in French (and it's probably the same problem for any translated language). Somehow, the 0 disappears during the translation process. When replaced by the html code referring to the "0" character, the translation works fine.