Summary: | CSV profile encoding not selected on editing | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Tools | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
Bug 9954 - CVS profile encoding not selected in edition [PASSED QA] Bug 9954 - CVS profile encoding not selected in edition |
Description
Fridolin Somers
2013-03-29 13:53:17 UTC
Created attachment 17029 [details] [review] Proposed patch See commit message Created attachment 17072 [details] [review] Bug 9954 - CVS profile encoding not selected in edition When editing an existing CSV profile, its encoding is not selected in combobox, first value "ascii" is always selected. This patch corrects this (surely appeared with TT conversion) and also the fact that "uft8" is by default selected in creation form. Test plan: - Go to Tools/CSV Profiles - In "New prodile" tab => Check that "uft8" is selected - Create a new profile by entering name, an encoding (other than the first), and MARC fields - Click on "Edit existing profile" tab - Select created profile => Check that specified encoding is selected Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 17086 [details] [review] [PASSED QA] Bug 9954 - CVS profile encoding not selected in edition When editing an existing CSV profile, its encoding is not selected in combobox, first value "ascii" is always selected. This patch corrects this (surely appeared with TT conversion) and also the fact that "uft8" is by default selected in creation form. Test plan: - Go to Tools/CSV Profiles - In "New prodile" tab => Check that "uft8" is selected - Create a new profile by entering name, an encoding (other than the first), and MARC fields - Click on "Edit existing profile" tab - Select created profile => Check that specified encoding is selected Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only change. Fixed tabs. This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12 |