Summary: | Missing cancel link on subfield editing page | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 9957 - Missing cancel link on subfield editing page
Bug 9957 - Missing cancel link on subfield editing page [PASSED QA] Bug 9957 - Missing cancel link on subfield editing page |
Description
Katrin Fischer
2013-03-31 11:33:15 UTC
Created attachment 17852 [details] [review] Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. Created attachment 17858 [details] [review] Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 17860 [details] [review] [PASSED QA] Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, improves consistency and works nicely. This patch has been pushed to master and 3.12.x. Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 |