Summary: | Incorrect index used for 'Standard number' in advanced search | ||
---|---|---|---|
Product: | Koha | Reporter: | Silvia Rus <rus.silvia> |
Component: | Searching | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bibliwho, fridolin.somers, m.de.rooy, martin.renvoize, nick, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9968: Fix wrong index for Standard number in advanced and label search
Bug 9968: Fix wrong index for Standard number in advanced and label search Bug 9968: Fix wrong index for Standard number in advanced and label search |
Description
Silvia Rus
2013-04-02 10:01:06 UTC
Created attachment 75351 [details] [review] Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number Not sure if related, but no searches of any kind work in Sandbox 14, on either the staff or OPAC side (database 1, w/ 450 records). Unable to test :-( This only touches some template files so should not be related. Could you try another box? Maybe take a look and switch the searchengine preference to Zebra. It's unclear to me from the test plan what the expected results should be when the [Intranet|OPAC]NumbersPreferPhrase system preferences are toggled. *General* Standard number searches work in Sandbox 05 when these are set to Use (the operator "phr" in the callnumber and standard number staff client searches). They fail when set to Don't use. (Searches using the specific ISBN & ISSN fields work with both settings.) Label creation works fine with either setting as long as ISBN or ISSN is set as the search field. No results, however, with either setting when searching by the general Standard number field. Created attachment 79862 [details] [review] Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number Signed-off-by: Michal Denar <black23@gmail.com> Thx Michal! Created attachment 80020 [details] [review] Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.05 Pushed to 17.11.x for 17.11.12 |