Bug 9985

Summary: The -r option to build-git-snapshot works only half way
Product: Koha Reporter: Magnus Enger <magnus>
Component: PackagingAssignee: Bugs List <koha-bugs>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P5 - low CC: mirko, robin
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Magnus Enger 2013-04-03 14:03:06 UTC
When I run debian/build-git-snapshot with "-r /home/magnus/packages/" I get some files in /home/magnus/packages/ and some files in the directory above the one in which i run debian/build-git-snapshot. Could this be fixed, so everything ends up in the directory specified by -r? 

Here is how the files are distributed:

$ cd /home/magnus
$ ls
koha_3.11-1~git+20130403+20130403144843.7b1a091a.dsc
koha_3.11-1~git+20130403+20130403144843.7b1a091a_source.changes
koha_3.11-1~git+20130403+20130403144843.7b1a091a_i386.build
koha_3.11-1~git+20130403+20130403144843.7b1a091a.tar.gz
$ ls packages/
koha_3.11-1~git+20130403+20130403144843.7b1a091a_all.deb
koha_3.11-1~git+20130403+20130403144843.7b1a091a.tar.gz
koha-perldeps_3.11-1~git+20130403+20130403144843.7b1a091a_all.deb
koha_3.11-1~git+20130403+20130403144843.7b1a091a.dsc
koha-common_3.11-1~git+20130403+20130403144843.7b1a091a_all.deb
koha_3.11-1~git+20130403+20130403144843.7b1a091a_i386.changes
koha-deps_3.11-1~git+20130403+20130403144843.7b1a091a_all.deb
Comment 1 Robin Sheat 2013-04-03 21:31:21 UTC
-r is used to specify where the build results go. The extra files aren't really build results, but are intermediate things, so it's not ideal that they go to the same place. It would be nice not to have them dropped in .., the reason it's like that is that it's the way debian tends to work. You'd have the same thing if you just ran debuild in there.

We could move those things somewhere else, but they shouldn't go to the -r place.
Comment 2 Magnus Enger 2013-04-03 21:42:27 UTC
Ah, I see. Would an automatically created subdirectory of the -r place make sense? Or /tmp? Or maybe this is just a WONTFIX...
Comment 3 Robin Sheat 2013-04-07 22:29:45 UTC
Perhaps another option to move them to a specific location is the best bet. In theory it's useful to have the tar.gz in the parent directory so it can be reused by things, in practice I don't think anyone does that for Koha.
Comment 4 Mirko Tietgen 2018-10-12 08:05:15 UTC
The files are placed in .. because Debian packaging tools expect it that way. To build the deb file, to run lintian etc. Setting this to wontfix.