Summary: | Two fixes on Z3950 Search | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Z39.50 / SRU / OpenSearch Servers | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | bgkriegel, chris, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 9986: Two fixes for Z3950 search
Bug 9986: Two fixes for Z3950 search Bug 9986: Two fixes for Z3950 search [SIGNED-OFF] Bug 9986: Two fixes for Z3950 search [PASSED QA] Bug 9986: Two fixes for Z3950 search |
Description
Marcel de Rooy
2013-04-03 14:36:48 UTC
Created attachment 17171 [details] [review] Bug 9986: Two fixes for Z3950 search Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work anymore. Probably my fault :) Note that these two fields are in Cataloging Z3950 search and not in Acquisition. Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and cataloging/z3950, the decoding statements in C4/Breeding, Z3950Search should be removed. Test plan: Search in Cataloging with: Standard ID: 9782358670043 on LOC RAW (any): musée on LOC -- Note the diacritic Search in Acquisition Somewhere, does not matter, but use a diacritic. Problem with é in the commit message.. Created attachment 17172 [details] [review] Bug 9986: Two fixes for Z3950 search Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work anymore. Probably my fault :) Note that these two fields are in Cataloging Z3950 search and not in Acquisition. Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and cataloging/z3950, the decoding statements in C4/Breeding, Z3950Search should be removed. Test plan: Search in Cataloging with: Standard ID: 9782358670043 on LOC RAW (any): musée on LOC -- Note the diacritic Search in Acquisition Somewhere, does not matter, but use a diacritic. Created attachment 17173 [details] [review] Bug 9986: Two fixes for Z3950 search Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work anymore. Probably my fault :) Note that these two fields are in Cataloging Z3950 search and not in Acquisition. Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and cataloging/z3950, the decoding statements in C4/Breeding, Z3950Search should be removed. Test plan: Search in Cataloging with: Standard ID: 9782358670043 on LOC RAW (any): musee [add an accent aigu on first e] on LOC -- Add diacritic!!! Search in Acquisition Somewhere, does not matter, but use a diacritic. A note: My git version still has a hard time with utf8. Need to upgrade to version 1.7.10 to resolve this.. Created attachment 17258 [details] [review] [SIGNED-OFF] Bug 9986: Two fixes for Z3950 search Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work anymore. Probably my fault :) Note that these two fields are in Cataloging Z3950 search and not in Acquisition. Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and cataloging/z3950, the decoding statements in C4/Breeding, Z3950Search should be removed. Test plan: Search in Cataloging with: Standard ID: 9782358670043 on LOC RAW (any): musee [add an accent aigu on first e] on LOC -- Add diacritic!!! Search in Acquisition Somewhere, does not matter, but use a diacritic. A note: My git version still has a hard time with utf8. Need to upgrade to version 1.7.10 to resolve this.. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors Without patch z39.50 search for example Std ID OR musée gives no results, with patch there are. No problems in acq search. Created attachment 17262 [details] [review] [PASSED QA] Bug 9986: Two fixes for Z3950 search Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work anymore. Probably my fault :) Note that these two fields are in Cataloging Z3950 search and not in Acquisition. Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and cataloging/z3950, the decoding statements in C4/Breeding, Z3950Search should be removed. Test plan: Search in Cataloging with: Standard ID: 9782358670043 on LOC RAW (any): musee [add an accent aigu on first e] on LOC -- Add diacritic!!! Search in Acquisition Somewhere, does not matter, but use a diacritic. A note: My git version still has a hard time with utf8. Need to upgrade to version 1.7.10 to resolve this.. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors Without patch z39.50 search for example Std ID OR musee gives no results, with patch there are. No problems in acq search. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Good catch, passes all tests and QA script. This patch has been pushed to master and 3.12.x. Does not apply to 3.10.x please send a new patch if it is needed |