Bug 9997

Summary: Suspected typo in patron self registration code
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: PatronsAssignee: Kyle M Hall <kyle.m.hall>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 9997 - Suspected typo in patron self registration code
[SIGNED-OFF] Bug 9997 - Suspected typo in patron self registration code
[PASSED QA] Bug 9997 - Suspected typo in patron self registration code

Description Katrin Fischer 2013-04-08 08:04:02 UTC
While translating this:

%s %s [%% SET field_display_names = { surname => "Surname" firstname => "First name" title => "Title" othernames => "Other names" initials => "Initials" streetnumber => "Street number" streettype => "Street type" address => "Address" address2 => "Address 2" city => "City" state => "State" zipcode => "Zip code" country => "Country" email => "Email" phone => "Primary Phone" mobile => "Primary Mobile Phone" fax => "Fax" emailpro => "Secondary email" phonepro => "Secondary phone" B_streetnumber => "Alternate address - street number" B_streettype => "Alternate address - street type" B_address => "Alternate address" B_address2 => "Alternate address 2" B_city => "Alternate address - city" B_state => "Alternate address - state" B_zipcode => "Alternate address - zip code" B_email => "Alternate address - email" B_phone => "Alertnate address - phone" dateofbirth => "Date of birth" contactname => "Contact - last name" contactfirstname=> "Contact - first name" contacttitle => "Contact - title" relationship => "Contact - relationship" ethnicity => "Ethnicity" ethnotes => "Ethnicity notes" sex => "Sex" altcontactfirstname => "Alternate contact - first name" altcontactsurname => "Alternate contact - surname" altcontactaddress1 => "Alternate contact - address" altcontactaddress2 => "Alternate contact - address 2" altcontactaddress3 => "Alternate contact - city" altcontactstate => "Alternate contact - state" altcontactzipcode => "Alternate contact - zip code" altcontactcounty => "Alternate contact - county" altcontactphone => "Alternate contact - phone" smsalertnumber => "SMS alert number" } %%] 

I was wondering if 
altcontactcounty => "Alternate contact - county" shouldn't be country to match the field in the database?
Comment 1 Kyle M Hall (khall) 2013-04-08 13:33:01 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-04-08 15:00:10 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-04-09 21:19:15 UTC
Created attachment 17324 [details] [review]
[PASSED QA] Bug 9997 - Suspected typo in patron self registration code

String fix. The field name is also incorrect, causing the alternate
contact country to not be stored.

To test: Submit an update to an existing patron record an include a
change to the alternate contact's country field. Before the patch this
line would not appear in the staff client for approval. After the patch
it should.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Reminder: Even small patches require test plans. I have added one which
I think covers the changes in the patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass.
Comment 4 Jared Camins-Esakov 2013-04-18 12:33:34 UTC
This patch has been pushed to master and 3.12.x.