Bug 10313 - selecting an invoice from the historic orders page does not take you to that invoice
Summary: selecting an invoice from the historic orders page does not take you to that ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Colin Campbell
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-22 18:27 UTC by Colin Campbell
Modified: 2014-12-07 20:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.83 KB, patch)
2013-05-22 18:46 UTC, Colin Campbell
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10313 Fix link to invoice from orders (1.87 KB, patch)
2013-05-23 14:01 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 10313 Fix link to invoice from orders (1.95 KB, patch)
2013-05-23 14:10 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2013-05-22 18:27:05 UTC
To reproduce search for historic orders from the acquisitions home screen. Click on a displayed invoice number you will be taken to a receipt screen but not to the items on that invoice. The correct linking key needs to be passed
Comment 1 Colin Campbell 2013-05-22 18:46:43 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2013-05-23 14:01:21 UTC Comment hidden (obsolete)
Comment 3 Julian Maurice 2013-05-23 14:02:28 UTC
Simple patch, easy to test
Comment 4 Jonathan Druart 2013-05-23 14:09:55 UTC
QA comment:

Clearly a bug.
Another bug exist on the parcel page, I will open a new report.

Marked as Passed QA.
Comment 5 Jonathan Druart 2013-05-23 14:10:10 UTC
Created attachment 18351 [details] [review]
Bug 10313 Fix link to invoice from orders

Need to have invoiceid and pass it to retrieve selected
invoicenumber. Wrong data passed causing incorrect
records to be displayed

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Galen Charlton 2013-05-23 14:56:45 UTC
Pushed to master.  Thanks, Colin!
Comment 7 Tomás Cohen Arazi 2013-06-03 14:28:12 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.
Comment 8 Bernardo Gonzalez Kriegel 2013-06-06 01:34:34 UTC
Pushed to 3.10.x, will be in 3.10.7