Bug 10807 - OPAC: There is no authority search history
Summary: OPAC: There is no authority search history
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 10677 10862 10933 11430
  Show dependency treegraph
 
Reported: 2013-08-30 07:52 UTC by Jonathan Druart
Modified: 2015-06-04 23:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10807: Add an authority search history for the OPAC (57.15 KB, patch)
2013-08-30 12:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX if zebra is down, total is undef (880 bytes, patch)
2013-09-03 07:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Add an authority search history for the OPAC (57.17 KB, patch)
2013-09-10 13:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX if zebra is down, total is undef (886 bytes, patch)
2013-09-10 13:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC (57.27 KB, patch)
2013-09-11 14:11 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10807: FIX if zebra is down, total is undef (1.13 KB, patch)
2013-09-11 14:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10807 [Follow-up] OPAC: There is no authority search history (3.85 KB, patch)
2013-09-11 14:12 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10807 [Follow-up] OPAC: There is no authority search history (3.87 KB, patch)
2013-09-13 07:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Change the GPL version to v3+ (1.94 KB, patch)
2013-09-23 11:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t (2.21 KB, patch)
2013-09-23 11:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: The new field search_history.type should be a varchar(16) (2.04 KB, patch)
2013-09-24 09:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Add an authority search history for the OPAC (56.23 KB, patch)
2013-10-30 08:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX if zebra is down, total is undef (1.08 KB, patch)
2013-10-30 08:51 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807 [Follow-up] OPAC: There is no authority search history (3.87 KB, patch)
2013-10-30 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Change the GPL version to v3+ (1.94 KB, patch)
2013-10-30 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t (2.21 KB, patch)
2013-10-30 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: The new field search_history.type should be a varchar(16) (2.04 KB, patch)
2013-10-30 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Add an authority search history for the OPAC (56.24 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX if zebra is down, total is undef (1.08 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807 [Follow-up] OPAC: There is no authority search history (3.87 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Change the GPL version to v3+ (1.94 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t (2.21 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: The new field search_history.type should be a varchar(16) (2.04 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Add an authority search history for the OPAC - bootstrap (14.11 KB, patch)
2013-12-19 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX conflicts with bug 10380 (1.68 KB, patch)
2013-12-20 14:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Add an authority search history for the OPAC (55.16 KB, patch)
2014-01-13 11:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807 [Follow-up] OPAC: There is no authority search history (3.83 KB, patch)
2014-01-13 11:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Change the GPL version to v3+ (1.94 KB, patch)
2014-01-13 11:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t (2.21 KB, patch)
2014-01-13 11:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: The new field search_history.type should be a varchar(16) (2.05 KB, patch)
2014-01-13 11:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10807: Add an authority search history for the OPAC - bootstrap (14.11 KB, patch)
2014-01-13 11:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 10807: Add an authority search history for the OPAC (55.54 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10807 [Follow-up] OPAC: There is no authority search history (3.90 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10807: Change the GPL version to v3+ (2.01 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t (2.27 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16) (2.11 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10807: Add an authority search history for the OPAC - bootstrap (14.17 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10807: Follow-up: Change wording of tabs (2.17 KB, patch)
2014-04-21 20:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-08-30 07:52:53 UTC

    
Comment 1 Jonathan Druart 2013-08-30 12:25:26 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-09-03 07:33:30 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-09-10 13:05:25 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-09-10 13:05:44 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2013-09-11 14:11:15 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2013-09-11 14:11:25 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2013-09-11 14:12:05 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2013-09-13 07:22:31 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2013-09-13 07:24:03 UTC
Owen,
Thank you for the followup, I let you change the status to "signed off" if it is good for you.
Comment 10 Jonathan Druart 2013-09-13 07:27:03 UTC
Hum(In reply to Jonathan Druart from comment #9)
> Owen,
> Thank you for the followup, I let you change the status to "signed off" if
> it is good for you.

I didn't change it on purpose :) So... since 2 first patchs has been signed off, I suppose the status is correct.
Comment 11 Katrin Fischer 2013-09-22 15:10:31 UTC
Hi Jonathan, 

could you take a look at the license and check if you want to update to GPL3?
 FAIL	C4/Search/History.pm
   OK	  pod
   FAIL	  forbidden patterns
		forbidden pattern: Koha is now under the GPLv3 license (line 261)
   OK	  valid
   OK	  critic

Continueing testing...
Comment 12 Katrin Fischer 2013-09-22 16:03:36 UTC
Hi Jonathan,

I wonder if PurgeSearchHistory should be moved into the new module, what do you think? It was introduced by bug 10361.
Comment 13 Katrin Fischer 2013-09-22 16:19:14 UTC
Some more notes:

1) The subs in Search:History.pm don't seem to follow our usual naming
   conventions. I am a bit unsure about this.

2) Shouldn't Search_SearchHistory.t be Search_History.t?

3) Search_SearchHistory.t also fails for me:

[~/kohaclone (52-10807-authoritysearchhistory)]> prove t/db_dependent/Search_SearchHistory.t 
t/db_dependent/Search_SearchHistory.t .. 1/6 
#   Failed test 'use C4::Search;'
#   at t/db_dependent/Search_SearchHistory.t line 24.
#     Tried to use 'C4::Search'.
#     Error:  "AddSearchHistory" is not exported by the C4::Search module
# Can't continue after import errors at (eval 26) line 2
# BEGIN failed--compilation aborted at (eval 26) line 2.
t/db_dependent/Search_SearchHistory.t .. 2/6 Undefined subroutine &main::AddSearchHistory called at t/db_dependent/Search_SearchHistory.t line 39.
# Looks like you planned 6 tests but ran 2.
# Looks like you failed 1 test of 2 run.
# Looks like your test exited with 255 just after 2.
t/db_dependent/Search_SearchHistory.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 5/6 subtests 

Failing for 3), but please check with Galen about 1) if possible and take a look at the other comments. Thx!
Comment 14 Jonathan Druart 2013-09-23 11:44:27 UTC
(In reply to Katrin Fischer from comment #11)
> Hi Jonathan, 
Katrin,


> could you take a look at the license and check if you want to update to GPL3?
>  FAIL	C4/Search/History.pm
>    OK	  pod
>    FAIL	  forbidden patterns
> 		forbidden pattern: Koha is now under the GPLv3 license (line 261)
Will be fixed in a followup.

(In reply to Katrin Fischer from comment #12)
> I wonder if PurgeSearchHistory should be moved into the new module, what do
> you think? It was introduced by bug 10361.

I open a new report for that : bug 10933.

(In reply to Katrin Fischer from comment #13)
> Some more notes:
> 
> 1) The subs in Search:History.pm don't seem to follow our usual naming
>    conventions. I am a bit unsure about this.

I wasn't aware about this rule. I just see it's in the coding guidelines but I am wondering if it is currently the case. Looking at the Koha namespace a lot of modules don't use the CamelCase notation.

> 2) Shouldn't Search_SearchHistory.t be Search_History.t?

Not from this patch. Bug 10933 will delete this file.

> 3) Search_SearchHistory.t also fails for me:

I will fix that!
Comment 15 Jonathan Druart 2013-09-23 11:45:11 UTC Comment hidden (obsolete)
Comment 16 Jonathan Druart 2013-09-23 11:45:16 UTC Comment hidden (obsolete)
Comment 17 Galen Charlton 2013-09-23 22:42:03 UTC
Comment on attachment 20988 [details] [review]
[SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC

Review of attachment 20988 [details] [review]:
-----------------------------------------------------------------

For follow-up.

::: C4/Search/History.pm
@@ +1,2 @@
> +package C4::Search::History;
> +

Why not Koha::Search::History since it's a new module?

::: installer/data/mysql/kohastructure.sql
@@ +1879,4 @@
>    `sessionid` varchar(32) NOT NULL, -- a system generated session id
>    `query_desc` varchar(255) NOT NULL, -- the search that was performed
>    `query_cgi` text NOT NULL, -- the string to append to the search url to rerun the search
> +  `type` varchar(255) NOT NULL DEFAULT 'biblio', -- search type, must be 'biblio' or 'authority'

varchar(255) is too wide for this if the only values are either 'biblio' or 'authority'.
Comment 18 Galen Charlton 2013-09-23 22:43:17 UTC
(In reply to Jonathan Druart from comment #14)
> > 1) The subs in Search:History.pm don't seem to follow our usual naming
> >    conventions. I am a bit unsure about this.
> 
> I wasn't aware about this rule. I just see it's in the coding guidelines but
> I am wondering if it is currently the case. Looking at the Koha namespace a
> lot of modules don't use the CamelCase notation.

Yeah, we haven't been consistent.  I have no strong feelings one way or the other.
Comment 19 Chris Cormack 2013-09-23 22:49:33 UTC
(In reply to Galen Charlton from comment #18)
> (In reply to Jonathan Druart from comment #14)
> > > 1) The subs in Search:History.pm don't seem to follow our usual naming
> > >    conventions. I am a bit unsure about this.
> > 
> > I wasn't aware about this rule. I just see it's in the coding guidelines but
> > I am wondering if it is currently the case. Looking at the Koha namespace a
> > lot of modules don't use the CamelCase notation.
> 
> Yeah, we haven't been consistent.  I have no strong feelings one way or the
> other.

Me either, except I think that for a module that isn't OO, get is a bad name for a subroutine.

If it were $history->get() I'd be ok with that. But having to fully qualify it Search::History::get() to make it meaningful I think is a bit clumsy.
Comment 20 Galen Charlton 2013-09-23 22:53:16 UTC
(In reply to Chris Cormack from comment #19)
> Me either, except I think that for a module that isn't OO, get is a bad name
> for a subroutine.
> 
> If it were $history->get() I'd be ok with that. But having to fully qualify
> it Search::History::get() to make it meaningful I think is a bit clumsy.

Indeed, although a fully-qualified Search::History::get() might be better than optionally exporting a GetSearchHistory().

But I think we're more or less on the same page -- best of all would be turning it into a class, and I think that could be done with only a small effort.
Comment 21 Jonathan Druart 2013-09-24 09:30:25 UTC
(In reply to Galen Charlton from comment #20)
> (In reply to Chris Cormack from comment #19)
> > Me either, except I think that for a module that isn't OO, get is a bad name
> > for a subroutine.
> > 
> > If it were $history->get() I'd be ok with that. But having to fully qualify
> > it Search::History::get() to make it meaningful I think is a bit clumsy.
> 
> Indeed, although a fully-qualified Search::History::get() might be better
> than optionally exporting a GetSearchHistory().
> 
> But I think we're more or less on the same page -- best of all would be
> turning it into a class, and I think that could be done with only a small
> effort.

Hello Chris and Galen,
I created the module in the C4 namespace precisely because it is not a OO module.
There are some doubt (at least for me) about how to create a new module into Koha: Dbix will arrive shortly (or not), Moo, Class::Accessor, etc.
The last time I thought I created a correct module (bug 10363), the patch has been ejected in the discussion status.
With this patch, I simply tried to group search history code into a module in order to re-use it somewhere else (bug 10862).
Comment 22 Jonathan Druart 2013-09-24 09:30:45 UTC Comment hidden (obsolete)
Comment 23 Galen Charlton 2013-09-24 14:50:01 UTC
(In reply to Jonathan Druart from comment #21)
> I created the module in the C4 namespace precisely because it is not a OO
> module.

I don't recall there be any requirement that the Koha names *only* be for OO-modules.  New modules should preferentially be OO, but there is a place in Koha for modules that are simply collections of utility code.

In this case, Koha::Search::History can be readily made OO, IMO.

> There are some doubt (at least for me) about how to create a new module into
> Koha: Dbix will arrive shortly (or not), Moo, Class::Accessor, etc.

I suggest running with Class::Accessor -- there are plenty of examples in the Koha namespace already.
Comment 24 Jonathan Druart 2013-09-24 15:43:09 UTC
(In reply to Galen Charlton from comment #23)
> I suggest running with Class::Accessor -- there are plenty of examples in
> the Koha namespace already.

What I did in bug 10862.
Comment 25 Jonathan Druart 2013-09-25 08:31:55 UTC
(In reply to Galen Charlton from comment #23)
> (In reply to Jonathan Druart from comment #21)
> > I created the module in the C4 namespace precisely because it is not a OO
> > module.
> 
> I don't recall there be any requirement that the Koha names *only* be for
> OO-modules.  New modules should preferentially be OO, but there is a place
> in Koha for modules that are simply collections of utility code.

Galen,

It is in the coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriented_code_and_the_Koha::_namespace
To me this module is not perfect (by far). So I had a preference for submitting the module as it into the C4 namespace.

> In this case, Koha::Search::History can be readily made OO, IMO.

I will try to move the existing module to the Koha namespace. But I prefer to do it after these patches (and patches from bug 10862) will be pushed.

Hope that make sense.
Comment 26 Jonathan Druart 2013-10-30 08:51:52 UTC Comment hidden (obsolete)
Comment 27 Jonathan Druart 2013-10-30 08:51:59 UTC Comment hidden (obsolete)
Comment 28 Jonathan Druart 2013-10-30 08:52:05 UTC Comment hidden (obsolete)
Comment 29 Jonathan Druart 2013-10-30 08:52:10 UTC Comment hidden (obsolete)
Comment 30 Jonathan Druart 2013-10-30 08:52:15 UTC Comment hidden (obsolete)
Comment 31 Jonathan Druart 2013-10-30 08:52:19 UTC Comment hidden (obsolete)
Comment 32 Jonathan Druart 2013-12-19 14:23:10 UTC Comment hidden (obsolete)
Comment 33 Jonathan Druart 2013-12-19 14:23:18 UTC Comment hidden (obsolete)
Comment 34 Jonathan Druart 2013-12-19 14:23:26 UTC Comment hidden (obsolete)
Comment 35 Jonathan Druart 2013-12-19 14:23:33 UTC Comment hidden (obsolete)
Comment 36 Jonathan Druart 2013-12-19 14:23:42 UTC Comment hidden (obsolete)
Comment 37 Jonathan Druart 2013-12-19 14:23:50 UTC Comment hidden (obsolete)
Comment 38 Jonathan Druart 2013-12-19 14:23:57 UTC Comment hidden (obsolete)
Comment 39 Jonathan Druart 2013-12-19 14:24:55 UTC
I fixed a conflict in the first patch and add a new patch for the bootstrap theme.
Comment 40 Jonathan Druart 2013-12-20 14:27:32 UTC Comment hidden (obsolete)
Comment 41 Katrin Fischer 2014-01-12 11:20:48 UTC
Hi Jonathan, I am sorry, but there are too many conflicts outside of updatedatabase. Could you please rebase?
Comment 42 Jonathan Druart 2014-01-13 11:58:36 UTC Comment hidden (obsolete)
Comment 43 Jonathan Druart 2014-01-13 11:58:47 UTC Comment hidden (obsolete)
Comment 44 Jonathan Druart 2014-01-13 11:58:52 UTC Comment hidden (obsolete)
Comment 45 Jonathan Druart 2014-01-13 11:58:57 UTC Comment hidden (obsolete)
Comment 46 Jonathan Druart 2014-01-13 11:59:03 UTC Comment hidden (obsolete)
Comment 47 Jonathan Druart 2014-01-13 11:59:08 UTC Comment hidden (obsolete)
Comment 48 Jonathan Druart 2014-01-13 12:00:11 UTC
Last patches fix big conflict with bug 10952.
Comment 49 Katrin Fischer 2014-01-13 20:44:19 UTC
Starting to test...
Comment 50 Katrin Fischer 2014-04-18 13:53:18 UTC
Sorry, I forgot a bit about this :( Resettig the QA contact, so if someone gets  to this before I do - feel free to take over!
Comment 51 Katrin Fischer 2014-04-21 16:02:34 UTC
Back on this.
Comment 52 Katrin Fischer 2014-04-21 18:46:47 UTC
Comment on attachment 24221 [details] [review]
Bug 10807: Add an authority search history for the OPAC

Review of attachment 24221 [details] [review]:
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +251,5 @@
>  
>              # If at least one search has already been performed
>              if ($sth->fetchrow_array > 0) {
> +                # We show the link in opac
> +                $template->param( EnableOpacSearchHistory => 1 );

I am not sure renaming the variable was necessary. 
Now it shows up in the templates like the system preference, although there is another condition that it takes into account. Also tempting to replace it with the TT plugin accidentally.
Comment 53 Katrin Fischer 2014-04-21 20:16:26 UTC
Created attachment 27372 [details] [review]
[PASSED QA] Bug 10807: Add an authority search history for the OPAC

Like biblio, this feature provides an authority search history.
This history is available for connected and disconnected user.
If the user is not logged in Koha, the history is stored in a cookie
named 'KohaOpacRecentSearches'.
The search history feature is now factorized in a new module.

This patch adds:
- 1 new db field search_history.type. It permits to distinguish the
  search type (biblio or authority).
- 1 new module C4::Search::History. It deals with 2 different storages:
  db or cookie
- 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t
- 1 new behavior: the 'Search history' link (on the top-right corner of
  the screen) is always displayed.

Test plan:
 1/ Switch on the 'EnableOpacSearchHistory' syspref.
 2/ Go on the opac and log out.
 3/ Launch some biblio and authority searches.
 4/ Go on your search history page.
 5/ Check that all yours searches are displayed.
 6/ Click on some links and check that results are consistent.
 7/ Delete your biblio history searches.
 8/ Delete your authority searches history searches.
 9/ Launch some biblio and authority searches
10/ Delete all your history (cross on the top-right corner)
11/ Check that all your history search is empty.
12/ Launch some biblio and authority searches.
13/ Login to your account.
14/ Check that all previous searches are displayed.
15/ Launch some biblio and authority searches.
16/ Check that these previous searches are displayed under "Current
session".
17/ Play with the 4 delete links (current / previous and biblio /
authority).

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All patches together pass QA script and tests.
Also, new tests in t/db_dependent/ pass.

Tested in all 4 OPAC themes, being logged in and anonymous.
Anonymous search history will be appended to personal search
history after logging in.
Also verified that cleanup_database still purges search history,
now also including the authority searchs.
Comment 54 Katrin Fischer 2014-04-21 20:16:29 UTC
Created attachment 27373 [details] [review]
[PASSED QA] Bug 10807 [Follow-up] OPAC: There is no authority search history

This follow-up makes two changes:

1) Change "biblio" to "catalog" when referring to non-authority
   searches.
2) Make display of the authority search tab dependent on the
OpacAuthorities system preference. If OPAC authority searches are
disabled we shouldn't show a tab which will always be empty.

To test, view the OPAC search history page with the OpacAuthorities
preference both on and off.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 55 Katrin Fischer 2014-04-21 20:16:32 UTC
Created attachment 27374 [details] [review]
[PASSED QA] Bug 10807: Change the GPL version to v3+

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 56 Katrin Fischer 2014-04-21 20:16:35 UTC
Created attachment 27375 [details] [review]
[PASSED QA] Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 57 Katrin Fischer 2014-04-21 20:16:38 UTC
Created attachment 27376 [details] [review]
[PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16)

varchar(255) is too wide for "biblio" and "authority" values.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 58 Katrin Fischer 2014-04-21 20:16:41 UTC
Created attachment 27377 [details] [review]
[PASSED QA] Bug 10807: Add an authority search history for the OPAC - bootstrap

Patch for the bootstrap theme

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 59 Katrin Fischer 2014-04-21 20:16:44 UTC
Created attachment 27378 [details] [review]
Bug 10807: Follow-up: Change wording of tabs

Changed the tabs from Catalog and Authority to
Catalog searches and Authority searches to be a bit more specific.
Comment 60 Galen Charlton 2014-05-05 02:59:30 UTC
Pushed to master.  Thanks, Jonathan!