Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.
Summary: Transfer limits should be respected in the build_holds_queue.pl -script.
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P3 enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 11020
Blocks: 7376
  Show dependency treegraph
 
Reported: 2013-10-09 15:43 UTC by Olli-Antti Kivilahti
Modified: 2015-12-24 13:20 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. (22.08 KB, patch)
2013-10-15 10:48 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. (21.98 KB, patch)
2013-10-23 15:14 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. (21.90 KB, patch)
2013-11-04 11:33 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. (21.91 KB, patch)
2013-11-04 11:35 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. (45.91 KB, patch)
2013-11-26 16:52 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2013-10-09 15:43:11 UTC
No point in having fancy transfer limits if they cannot be targeted properly to respect the transfer limits.

Modify the holds targeter to respect transfer limits.
Comment 1 Olli-Antti Kivilahti 2013-10-15 10:48:39 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2013-10-23 15:14:43 UTC Comment hidden (obsolete)
Comment 3 Olli-Antti Kivilahti 2013-10-23 15:22:24 UTC
Fixed tabs to spaces in indentation.
Comment 4 Olli-Antti Kivilahti 2013-11-04 11:33:28 UTC Comment hidden (obsolete)
Comment 5 Olli-Antti Kivilahti 2013-11-04 11:35:21 UTC Comment hidden (obsolete)
Comment 6 Olli-Antti Kivilahti 2013-11-26 16:52:20 UTC
Created attachment 23166 [details] [review]
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

Formatted using perltidy and Perl::Critic
Comment 7 Kyle M Hall 2015-07-24 15:39:12 UTC
You've done a lot of perltidy-ing. Can you please split the actual code changes into a separate patch from the tidied code?

Thanks!
Comment 8 Olli-Antti Kivilahti 2015-07-27 09:06:25 UTC
Sorry I cannot focus at this atm.
Comment 9 Olli-Antti Kivilahti 2015-07-27 09:11:37 UTC
Quite frankly I am just now starting to recall this feature.
We don't use it atm.
There is a big design problem here:
    What happens if the queued Item is Lost (and we don't know that it is lost)?
    Does the Borrower waiting for the Lost Item have to wait forever, since the feature always gives the same Items on each iteration regardless of how long the Borrower has laready been waiting for his Item?
I have a good idea (on my opinion) on how to solve this issue, if you want to tackle it, let me know!
Comment 10 Marc Véron 2015-12-24 13:20:08 UTC
What is the current status of this bug? - It blocks a bug marked as critical: Bug 7376