Bug 11111 - The basket group is not displayed on the parcel page
Summary: The basket group is not displayed on the parcel page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 13333
  Show dependency treegraph
 
Reported: 2013-10-22 12:07 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11111: The basket group is not display on the parcel page (4.62 KB, patch)
2013-10-22 12:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGN-OFF]Bug 11111: The basket group is not display on the parcel page (4.68 KB, patch)
2013-10-22 16:33 UTC, Ed Veal
Details | Diff | Splinter Review
[PASSED QA] Bug 11111: The basket group is not display on the parcel page (4.86 KB, patch)
2013-10-27 03:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11111: The basket group is not display on the parcel page (5.19 KB, patch)
2013-11-04 08:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname (1.19 KB, patch)
2013-11-04 08:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11111: The basket group is not display on the parcel page (5.44 KB, patch)
2013-11-04 08:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname (1.19 KB, patch)
2013-11-04 08:36 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-10-22 12:07:08 UTC
Bug 10724 adds the search by basket group on the parcel page but does not display it the the table.
Comment 1 Jonathan Druart 2013-10-22 12:09:11 UTC Comment hidden (obsolete)
Comment 2 Ed Veal 2013-10-22 16:33:32 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-10-27 03:29:48 UTC Comment hidden (obsolete)
Comment 4 Galen Charlton 2013-11-01 00:37:27 UTC
Patch no longer applies, and this close to string freeze I don't want to risk messing up the merge conflict resolution.  Also, since this patch touches SearchOrders(), a unit test should be added.
Comment 5 Jonathan Druart 2013-11-04 08:33:34 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-11-04 08:33:45 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-11-04 08:35:53 UTC
Created attachment 22682 [details] [review]
Bug 11111: The basket group is not display on the parcel page

Test plan:
Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name
is displayed into the 2nd column.

Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changed basketgroup to basket group to match spelling on other
pages.
Works as described, passes tests and QA script.
Comment 8 Jonathan Druart 2013-11-04 08:36:00 UTC
Created attachment 22683 [details] [review]
Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname
Comment 9 Galen Charlton 2013-12-05 15:55:40 UTC
Pushed to master, along with a follow-up correcting column sorting.  Thanks, Jonathan!
Comment 10 Fridolin Somers 2013-12-13 16:07:51 UTC
Those patches have been pushed to 3.14.x, will be in 3.14.1