Bug 11226 - Working with serials now requires admin (parameters) permission
Summary: Working with serials now requires admin (parameters) permission
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-09 19:40 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions (24.29 KB, patch)
2013-11-12 13:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions (1.70 KB, patch)
2014-07-09 07:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions (1.88 KB, patch)
2014-07-10 14:57 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions (1.93 KB, patch)
2014-07-11 11:55 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-11-09 19:40:46 UTC
Only staff with 'parameters' (administration module) permission can add new frequencies and numbering patterns.

This makes it necessary to give serials librarians full permissions to the administration module.

Serials permissions should be handled separately.

Also, the links to manage frequencies and numbering patterns still show, when you don't have the appropriate permissions.
Comment 1 Jonathan Druart 2013-11-12 13:43:53 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-11-17 06:24:03 UTC
Jonathan, your patch includes changes to the .po file, I don't think that is intentional is it?

Other than that, it works fine. Happy to sign off when the .po changes are taken out.
Comment 3 Nicole C. Engard 2014-06-09 15:42:13 UTC
Checking in on this - it's still an issue for some of our libraries
Comment 4 Jonathan Druart 2014-07-09 07:50:42 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-07-09 07:51:30 UTC
Sorry, I completely forgot this patch.
I resubmitted without the po changes.
Comment 6 Bernardo Gonzalez Kriegel 2014-07-10 14:57:33 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2014-07-11 11:55:29 UTC
Created attachment 29625 [details] [review]
[PASSED QA] Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions

Bug 7688 does now allow patrons with serials permissions to edit
 subscription frequencies/numbering patterns.

 Test plan:
 Try to access to serials/subscription-frequencies.pl and
 serials/subscription-numberpatterns.pl with the "serials" permissions.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
With patch and only serial permissions can now access
frequences and patterns.
No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2014-07-14 14:32:56 UTC
Patch pushed to master.

Thanks Jonathan!
Comment 9 Galen Charlton 2014-07-23 21:36:07 UTC
Pushed to 3.16.x for inclusion in 3.16.2.
Comment 10 Fridolin Somers 2014-07-25 12:11:54 UTC
Pushed to 3.14.x, will be in 3.14.09