Bug 11409 - ungrouped baskets are not being displayed when creating a new basket group
Summary: ungrouped baskets are not being displayed when creating a new basket group
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-17 16:46 UTC by Galen Charlton
Modified: 2018-12-03 20:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11409: display ungrouped baskets when create new basket group (1.63 KB, patch)
2013-12-17 16:59 UTC, Galen Charlton
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Galen Charlton 2013-12-17 16:46:30 UTC
When creating a new basket group for a vendor, the open, ungrouped baskets are not being displayed in the right-hand text area.  Without this, it is impossible to add baskets to a basket group without using the option to close a basket and add it to a new group.
Comment 1 Galen Charlton 2013-12-17 16:59:10 UTC
Created attachment 23605 [details] [review]
Bug 11409: display ungrouped baskets when create new basket group

This patch fixes a problem where, when creating a new basket
group for a vendor, no open baskets were displayed in the
ungrouped baskets control, thereby making it impossible to add
baskets to the group from that interface.  This patch fixes that.

To test
-------
[1] Create some order baskets for a vendor.  Make sure that
    at least one of them gets closed.
[2] From the vendor details page, click the basket groups link
    and create a new basket group.
[3] Observe that none of the open baskets are available to be
    selected.
[4] Apply the patch and refresh.
[5] This time, the open baskets should be listed in the ungrouped
    baskets widget.
[6] Verify that you can move some baskets into the group and save
    the group.
[7] Verify that no closed baskets show up in the ungrouped baskets
    widget.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Comment 2 Galen Charlton 2013-12-17 17:32:24 UTC
Having looked into this more, I've now noticed the help text for the basket groups page:

  A basket group is a group of closed baskets that you can perform actions on.

In other words, if this is the case, this patch is invalid.  However, I'm leaving this bug open for discussion for the moment -- since both Tomas and I ended up with the same misconception that it should be possible to put open baskets into a group, others might have the same view.

This suggests to me that there might be a use case for being able to put baskets in a group before they get closed.  Even if that's not the case, it also suggests that the heading for the ungrouped baskets widget might be better as "Ungrouped closed baskets".
Comment 3 Nicole C. Engard 2013-12-17 17:34:58 UTC
Galen,

I have to admit that I am clueless about the point of a basket group in the first place. That said, you are correct (and the manual is correct) basket groups are only for closed baskets. You add them to the basket group when you close the basket - it's a question you're asked upon closing.  

If someone can explain to me why I'd want/need a basket group in the first place I might be able to say if we should have groups created before closing as well ... but right now I can come up with no reason.

Nicole
Comment 4 Tomás Cohen Arazi 2013-12-17 17:37:30 UTC
(In reply to Nicole C. Engard from comment #3)
> Galen,
> 
> I have to admit that I am clueless about the point of a basket group in the
> first place. That said, you are correct (and the manual is correct) basket
> groups are only for closed baskets. You add them to the basket group when
> you close the basket - it's a question you're asked upon closing.  
> 
> If someone can explain to me why I'd want/need a basket group in the first
> place I might be able to say if we should have groups created before closing
> as well ... but right now I can come up with no reason.

I guess it has to be related to printing. It looks like the only thing you can do with closed basket groups is print them.

Regards
To+
Comment 5 Nicole C. Engard 2013-12-17 17:52:04 UTC
(In reply to Tomás Cohen Arazi from comment #4)
> I guess it has to be related to printing. It looks like the only thing you
> can do with closed basket groups is print them.
> 
> Regards
> To+

Which is why I've never seen a US library use groups because printing means a PDF with 'Frenchisms' hard coded in.

Nicole
Comment 6 Katrin Fischer 2013-12-17 22:47:03 UTC
I think currently the point of basket groups is indeed printing and exporting of data. You can print a 3 page layout that include a kind of 'table of contents' of the basket group and then each basket on the following pages. Or you can have a 2 page layout that, which leaves out the toc and maks sense if you only want to print 1 order per PDF.I think it's now also possible to export CSV data, that will include the basket group information.

I found this post form Paul explaining some about the workflow:
http://lists.katipo.co.nz/public/koha/2013-September/037276.html

My feeling is that if we allow adding non-closed baskets to the basket group, they should probably be closed in the process.
You can ungroup a basket from its basket group. So ungrouped closed baskets should probably show up, but not totally sure about the open baskets.

Some of our libraries have expressed interest in PDF printing, but the PDF will have to be translated and maybe reformatted, which is currently not an easy task.
Comment 7 Marc Véron 2016-10-03 15:42:25 UTC
Still valid?

Are basket groups really used?
See http://lists.katipo.co.nz/public/koha/2013-September/037276.html from comment #6
Comment 8 Owen Leonard 2018-05-21 12:32:57 UTC
I'm closing this because the original bug stemmed from a misunderstanding and discussion of whether basket groups are worthwhile can take place elsewhere.