Bug 12011 - ReservesNeedReturns breaks 'Hold Filled' functionality
Summary: ReservesNeedReturns breaks 'Hold Filled' functionality
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Target Milestone: ---
Assignee: Bugs List
QA Contact: Testopia
: 12010 (view as bug list)
Depends on:
Reported: 2014-03-28 06:23 UTC by David Cook
Modified: 2018-03-15 13:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2014-03-28 06:23:23 UTC
If you have the system preference "ReservesNeedReturns" turned on, notices for "Holds Filled" won't be generated because the logic thinks that it has already sent one.

As far as I can tell, "notificationdate" doesn't even appear to be used. That seems like it would be an excellent place to record the date that a notice was sent out...
Comment 1 David Cook 2014-03-28 06:26:00 UTC
Ack. Sorry. Problem in my description.

I mean if "ReservesNeedReturns" is turned "OFF" it will create problems, because $found will automatically be 'W' which will turn on $already_on_shelf, which means that _koha_notify_reserve is never triggered in Reserves.pm...
Comment 2 Katrin Fischer 2014-11-21 06:55:22 UTC
*** Bug 12010 has been marked as a duplicate of this bug. ***