Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client
Summary: MSG_REMOVE_FROM_LIST different wording between OPAC and staff client
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 11901 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-03 04:58 UTC by paxed
Modified: 2015-12-03 22:03 UTC (History)
6 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client (3.45 KB, patch)
2014-04-03 12:47 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client (3.52 KB, patch)
2014-04-03 17:33 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client (3.58 KB, patch)
2014-04-04 08:49 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-04-03 04:58:47 UTC
Staff client: "Are you sure you want to remove these records from the shelf?"
OPAC: "Are you sure you want to remove these items from the list?"

Should probably pick one wording, and use that in both staff client and OPAC.
Comment 1 Owen Leonard 2014-04-03 12:47:36 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-04-03 17:33:44 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-04-04 08:49:44 UTC
Created attachment 26812 [details] [review]
Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client

The staff client lists template contains a warning which differs from
the same warning in the OPAC. The OPAC version is correct because it
refers to a list rather than a shelf. This patch copies the OPAC version
to the staff client template.

This patch also corrects a few of other instances where the incorrect
term "shelf" is used.

To test, apply the patch and view a list in the staff client which is
populated with items. Check the box next to one or more items on the
list and click the "Remove selected" button. You should see the message,
"Are you sure you want to remove these items from the list?"

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Work as described, no koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-04-04 15:32:43 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-07-11 06:57:37 UTC
Pushed to 3.14.x, will be in 3.14.09
Comment 6 Kyle M Hall (khall) 2014-07-14 11:27:07 UTC
Pushed to 3.12.x, will be in 3.12.14
Comment 7 Jonathan Druart 2015-04-24 10:50:36 UTC
*** Bug 11901 has been marked as a duplicate of this bug. ***