Staff client: "Are you sure you want to remove these records from the shelf?" OPAC: "Are you sure you want to remove these items from the list?" Should probably pick one wording, and use that in both staff client and OPAC.
Created attachment 26789 [details] [review] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client The staff client lists template contains a warning which differs from the same warning in the OPAC. The OPAC version is correct because it refers to a list rather than a shelf. This patch copies the OPAC version to the staff client template. This patch also corrects a few of other instances where the incorrect term "shelf" is used. To test, apply the patch and view a list in the staff client which is populated with items. Check the box next to one or more items on the list and click the "Remove selected" button. You should see the message, "Are you sure you want to remove these items from the list?"
Created attachment 26799 [details] [review] [SIGNED OFF] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client The staff client lists template contains a warning which differs from the same warning in the OPAC. The OPAC version is correct because it refers to a list rather than a shelf. This patch copies the OPAC version to the staff client template. This patch also corrects a few of other instances where the incorrect term "shelf" is used. To test, apply the patch and view a list in the staff client which is populated with items. Check the box next to one or more items on the list and click the "Remove selected" button. You should see the message, "Are you sure you want to remove these items from the list?" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors
Created attachment 26812 [details] [review] Bug 12034 - MSG_REMOVE_FROM_LIST different wording between OPAC and staff client The staff client lists template contains a warning which differs from the same warning in the OPAC. The OPAC version is correct because it refers to a list rather than a shelf. This patch copies the OPAC version to the staff client template. This patch also corrects a few of other instances where the incorrect term "shelf" is used. To test, apply the patch and view a list in the staff client which is populated with items. Check the box next to one or more items on the list and click the "Remove selected" button. You should see the message, "Are you sure you want to remove these items from the list?" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Owen!
Pushed to 3.14.x, will be in 3.14.09
Pushed to 3.12.x, will be in 3.12.14
*** Bug 11901 has been marked as a duplicate of this bug. ***