Bug 12052 - Display a patron message on the summary page
Summary: Display a patron message on the summary page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-09 08:34 UTC by Jonathan Druart
Modified: 2015-12-03 22:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12052: Display a patron message on the summary page (3.62 KB, patch)
2014-04-09 08:42 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12052: Display a patron message on the summary page (4.99 KB, patch)
2014-04-14 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12052: Display a patron message on the summary page (5.04 KB, patch)
2014-04-14 15:57 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12052: Display a patron message on the summary page (5.28 KB, patch)
2014-04-15 21:38 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12052: Display a patron message on the summary page (5.35 KB, patch)
2014-04-15 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-04-09 08:34:10 UTC
There is no way (or I missed something) to display a note for all patrons at the OPAC. The note should only be displayed if the user is logged in.
Comment 1 Jonathan Druart 2014-04-09 08:42:08 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-04-12 13:47:00 UTC
Works, but

1. Think you need to add the new syspref on installer/data/mysql/updatedatabase.pl
2. The check 
  if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
must be written
  if ( CheckVersion($DBversion) ) {
because it does not run as is on master
Comment 3 Jonathan Druart 2014-04-14 07:54:07 UTC
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> Works, but
> 
> 1. Think you need to add the new syspref on
> installer/data/mysql/updatedatabase.pl

In sysprefs.sql, yes :)

> 2. The check 
>   if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
> must be written
>   if ( CheckVersion($DBversion) ) {
> because it does not run as is on master

Oops, originally this patch was for a 3.10 branch, I forgot to change that.

New patch coming.
Comment 4 Jonathan Druart 2014-04-14 07:54:21 UTC Comment hidden (obsolete)
Comment 5 Bernardo Gonzalez Kriegel 2014-04-14 15:57:33 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-04-15 21:38:25 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-04-15 21:42:24 UTC
Created attachment 27151 [details] [review]
[PASSED QA] Bug 12052: Display a patron message on the summary page

Test plan:
Fill the OPACMySummaryNote with html code or just text.
The content should be displayed at the OPAC on the summary page for
patrons.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes tests and QA script.
Rephrased the pref text a little bit, using 'logged in' instead of
'connected', also added " so the description appears correctly in the
pref editor.
Comment 8 Galen Charlton 2014-04-15 22:37:48 UTC
Pushed to master.  Thanks, Jonathan!
Comment 9 Fridolin Somers 2014-08-06 09:40:22 UTC
Pushed to 3.14.x, will be in 3.14.10