Bug 12085 - Allow staff to place multiple reserves for the same patron
Summary: Allow staff to place multiple reserves for the same patron
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 13430
  Show dependency treegraph
 
Reported: 2014-04-15 09:28 UTC by paxed
Modified: 2016-08-10 16:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Allow multiple reserves for the same patron (19.56 KB, patch)
2014-04-15 09:28 UTC, paxed
Details | Diff | Splinter Review
Bug 12085 - Allow staff to place multiple reserves for the same patron (18.44 KB, patch)
2014-12-19 09:55 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
Bug 12085 - Allow staff to place multiple reserves for the same patron. Fix wrong branch from hold-transfer-slip.pl (4.51 KB, patch)
2014-12-19 09:55 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-04-15 09:28:03 UTC Comment hidden (obsolete)
Comment 1 Olli-Antti Kivilahti 2014-12-19 09:55:02 UTC
Created attachment 34522 [details] [review]
Bug 12085 - Allow staff to place multiple reserves for the same patron

This requires rather large changes to C4/Reserves.pm, because it didn't use the
reserve_id to distinguish the reserves.

 -Remove all vestiges of reserveconstraints -table from the code.
 -Make Reserves use ID numbers as much as possible, instead of matching
  with patron number, bibnum, and date.
 -Allow the same patron reserve the same item multiple times, but
  only via staff client.
Comment 2 Olli-Antti Kivilahti 2014-12-19 09:55:24 UTC
Created attachment 34523 [details] [review]
Bug 12085 - Allow staff to place multiple reserves for the same patron. Fix wrong branch from hold-transfer-slip.pl

1. Place lots of reservations for one borrower to be picked up from multiple branches.
2. Start checking the books in and catching the resevations.
3. Observe that the hold-transfer-slip is always for the first unsatisfied hold for the biblionumber, regardless
   of which hold is received. This only appears when checking-in multiple same biblios.

This patch fixes that.
Comment 3 Olli-Antti Kivilahti 2014-12-19 09:58:00 UTC
Rebased for 3.16.4.
Will rebase to master some day with unit tests.

Feel free to rip this code to whatever evil purposes.
As long as they are sufficiently evil to get this feature to master :)
Comment 4 Marcel de Rooy 2014-12-19 10:40:12 UTC
(In reply to Olli-Antti Kivilahti from comment #3)
> Rebased for 3.16.4.
> Will rebase to master some day with unit tests.
> 
> Feel free to rip this code to whatever evil purposes.
> As long as they are sufficiently evil to get this feature to master :)

It will certainly have my attention if you rebase it on master :)
And the opac side (there is already a report in FQA or DNA for that..) ?