On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column. It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count).
Created attachment 28838 [details] [review] Bug 12419: Not for loan items are not listed On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column. It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count). Test plan: 1/ Create 2 biblio records A and B 2/ Create some items for A 3/ Create 1+ item(s) for B with a notforloan status > 0 4/ Reindex both records 5/ Launch a search on the cataloguing module and verify that the notforloan items are not listed in the 'Location' column. 6/ Apply this patch and verify the not for loan items are listed ("Not for loan (XXX)").
I'am not sure at all that is the best way to fix this issue. Ideas welcomed.
Created attachment 28957 [details] [review] [SIGNED-OFF] Bug 12419: Not for loan items are not listed On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column. It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count). Test plan: 1/ Create 2 biblio records A and B 2/ Create some items for A 3/ Create 1+ item(s) for B with a notforloan status > 0 4/ Reindex both records 5/ Launch a search on the cataloguing module and verify that the notforloan items are not listed in the 'Location' column. 6/ Apply this patch and verify the not for loan items are listed ("Not for loan (XXX)"). Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Created attachment 29135 [details] [review] [PASSED QA] Bug 12419: Not for loan items are not listed On the cataloguing search (cataloguing/addbook.pl), if an item has a notforloan value > 0, the item is not listed in the Location column. It is quite confusing, the current behavior let patrons believe that there is not item for the biblio (or less than the real count). Test plan: 1/ Create 2 biblio records A and B 2/ Create some items for A 3/ Create 1+ item(s) for B with a notforloan status > 0 4/ Reindex both records 5/ Launch a search on the cataloguing module and verify that the notforloan items are not listed in the 'Location' column. 6/ Apply this patch and verify the not for loan items are listed ("Not for loan (XXX)"). Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, not for loan items now show up.
Created attachment 29384 [details] [review] Bug 12419: (QA followup) regression tests Changes to searchResults deserve unit tests. Edit: minor tweaks: - Remove warning in line 702 - Modernize - License added - "This file is a stub" removed Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 29385 [details] [review] Bug 12419: (QA followup) regression tests Changes to searchResults deserve unit tests. Edit: minor tweaks: - Remove warning in line 702 - Modernize - License added - "This file is a stub" removed Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Patch pushed to master. Thanks Jonathan!
Pushed to 3.16.x for inclusion in 3.16.4.