To test: - Run a custom report that produces results - Export as Open Document Spreadsheet - Verify export worked correctly - Run a custom report that produces no results - Export as Open Document Spreadsheet - Verify you see a perl error: Can't use an undefined value as an ARRAY reference at /usr/share/koha/intranet/cgi-bin/reports/guided_reports.pl line 817.
Created attachment 29952 [details] [review] Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines.
Created attachment 30067 [details] [review] Signed off patch Other exported report types seem to work with queries that produce no results
Created attachment 30074 [details] [review] [PASSED QA] Bug 12622: Fix export report as ods Bug 11679 introduces an ods export for reports. It looks quite buggy: 1/ You get a Perl error if the report has no results 2/ The ods file contains 1 lines less than the total results. Test plan: After applying this patch, try to export a report which has no results and verify you get an ods file with headers only. Try to export a report which has a least 1 result and verify the generated ods has the right number of lines. Signed-off-by: Robert Higgins <robert.higgins@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes the reported problem, passes all tests and QA script. Added the sign-off line for Robert.
Resetting Assigned to to Jonathan - as he is the patch writer. Thx for testing Robert!
Patch pushed to master. Thanks Jonathan!
Pushed to 3.16.x for inclusion in 3.16.3.
*** Bug 13010 has been marked as a duplicate of this bug. ***
*** Bug 12888 has been marked as a duplicate of this bug. ***