Bug 12835 - Acquisitions: Show search terms in z39.50 results
Summary: Acquisitions: Show search terms in z39.50 results
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 15:46 UTC by Marc Véron
Modified: 2015-06-04 23:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12835 - Acquisitions: Show search terms in z39.50 results (2.15 KB, patch)
2014-08-28 05:27 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12835 - Acquisitions: Show search terms in z39.50 results (2.01 KB, patch)
2014-09-04 13:17 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 12835 - Acquisitions: Show search terms in z39.50 results (2.11 KB, patch)
2014-09-05 15:26 UTC, Paola Rossi
Details | Diff | Splinter Review
[PASSED QA] Bug 12835 - Acquisitions: Show search terms in z39.50 results (2.18 KB, patch)
2014-09-07 21:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2014-08-27 15:46:51 UTC
The z39.50 search results in Acquisitions should display the search terms at the top of the page, similar to z39.50 search in Cataloging.
Comment 1 Marc Véron 2014-08-28 05:27:28 UTC Comment hidden (obsolete)
Comment 2 Paola Rossi 2014-09-04 12:55:39 UTC
I've applied the patch against master 3.17.00.018

On /cgi-bin/koha/cataloguing/z3950_search.pl, 10 search fields appear in the z39.50 search form. In the 5-th row of the search table the fields "Raw (any)" and "Standard ID" are shown.

On the contrary, on /cgi-bin/koha/acqui/z3950_search.pl, in the "Order from external source" form the search fields "Raw (any)" and "Standard ID" are not shown.

The patch manages the two fields, but it can't be tested about them. 

So I pass the patch to "Failed QA" status.
Comment 3 Marc Véron 2014-09-04 13:17:32 UTC Comment hidden (obsolete)
Comment 4 Paola Rossi 2014-09-05 15:26:00 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-09-07 21:55:06 UTC
Created attachment 31442 [details] [review]
[PASSED QA] Bug 12835 - Acquisitions: Show search terms in z39.50 results

To test:

- Go to Acquisitions, select a bookshop and a basket, click 'Add to basket':'From an external source'
- Do a search
- Your search terms should display at the top of the results page.
- Repeat search with several combinations of search terms (with and without results).

- Check the output for correct html.

Fields Raw (any) and Standard ID removed / MV

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script, works as described, no problems found.
Comment 6 Tomás Cohen Arazi 2014-09-08 13:58:04 UTC
Patch pushed to master.

Thanks Marc!