Created attachment 31856 [details] [review] Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects.
Created attachment 31977 [details] [review] Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables.
Created attachment 32149 [details] [review] Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects.
Created attachment 32150 [details] [review] Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables.
Created attachment 32348 [details] [review] Bug 12989: Update table footer with the visible rows - acqui-home I've applied the patches against master 3.17.00.027 I've applied (see also bug 12988): 0001-Bug-12979-Price-formatting-should-only-be-defined-at.patch 0002-Bug-12979-Fix-error-on-layout3pagesfr.patch 0003-Bug-12844-New-module-to-manage-prices-into-Koha.patch 0004-Bug-12844-Remove-the-C4-Output-FormatNumber-subrouti.patch 0005-Bug-12844-Use-Koha-Number-Price-where-it-can-be-usef.patch 0006-Bug-12844-FIX-import-package-missing.patch 0007-Bug-12844-Force-the-symbol-place-in-the-tests.patch 0008-Bug-12955-The-show-my-funds-only-should-be-take-into.patch 0009-Bug-12986-Upgrade-the-DataTables-jQuery-plugin-to-th.patch 0010-Bug-12987-Update-table-footer-with-the-visible-rows.patch 0011-Bug-12987-The-new-format_price-include-file-should-b.patch 0012-Bug-12988-Update-table-footer-with-the-visible-rows-.patch 0013-Bug-12984-Improvement-of-the-funds-list-view-acqui-h.patch 0014-Bug-12989-Update-table-footer-with-the-visible-rows-.patch 0015-Bug-12989-Fix-JS-error.patch I've tested setting either FR or US currencyformat syspref. Everything is OK. So I pass the patch to "Signed Off" status.
Created attachment 32349 [details] [review] Bug 12989: Fix JS error
Created attachment 32817 [details] [review] [PASSED QA] Bug 12989: Update table footer with the visible rows - acqui-home Note that bug 12984 changes the view of this table. On the acqui-home page, the total was not updated. With this patch, the footer (totals) will be updated on filtering rows. Test plan: 1/ Go on the acqui home page. 2/ Verify the totals are correct. 3/ Filter the table using the filter input and verify the totals are updated with the rows shown. 4/ Hide/Show inactive budgets and verify the totals are still corrects. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 32818 [details] [review] [PASSED QA] Bug 12989: Fix JS error inactive and active are not defined anymore. They should be removed. The filter is done with DataTables. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!