Bug 12989 - Update table footer with the visible rows - acqui-home
Summary: Update table footer with the visible rows - acqui-home
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 12984 12987
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-24 15:13 UTC by Jonathan Druart
Modified: 2015-06-04 23:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12989: Update table footer with the visible rows - acqui-home (5.30 KB, patch)
2014-09-24 15:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12989: Fix JS error (1.14 KB, patch)
2014-10-02 13:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12989: Update table footer with the visible rows - acqui-home (5.32 KB, patch)
2014-10-10 14:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12989: Fix JS error (1.14 KB, patch)
2014-10-10 14:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12989: Update table footer with the visible rows - acqui-home (5.49 KB, patch)
2014-10-15 15:15 UTC, Paola Rossi
Details | Diff | Splinter Review
Bug 12989: Fix JS error (1.23 KB, patch)
2014-10-15 15:16 UTC, Paola Rossi
Details | Diff | Splinter Review
[PASSED QA] Bug 12989: Update table footer with the visible rows - acqui-home (5.44 KB, patch)
2014-10-27 22:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12989: Fix JS error (1.25 KB, patch)
2014-10-27 22:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-09-24 15:13:02 UTC

    
Comment 1 Jonathan Druart 2014-09-24 15:25:42 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-10-02 13:54:05 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-10-10 14:26:11 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-10-10 14:26:21 UTC Comment hidden (obsolete)
Comment 5 Paola Rossi 2014-10-15 15:15:59 UTC Comment hidden (obsolete)
Comment 6 Paola Rossi 2014-10-15 15:16:31 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-10-27 22:50:44 UTC
Created attachment 32817 [details] [review]
[PASSED QA] Bug 12989: Update table footer with the visible rows - acqui-home

Note that bug 12984 changes the view of this table.

On the acqui-home page, the total was not updated.
With this patch, the footer (totals) will be updated on filtering rows.

Test plan:
1/ Go on the acqui home page.
2/ Verify the totals are correct.
3/ Filter the table using the filter input and verify the totals are
updated with the rows shown.
4/ Hide/Show inactive budgets and verify the totals are still corrects.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2014-10-27 22:52:14 UTC
Created attachment 32818 [details] [review]
[PASSED QA] Bug 12989: Fix JS error

inactive and active are not defined anymore. They should be removed. The
filter is done with DataTables.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2014-11-11 17:37:41 UTC
Patches pushed to master.

Thanks Jonathan!