Bug 13018 - Static fine should apply only once for a given borrower
Summary: Static fine should apply only once for a given borrower
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-01 09:53 UTC by Sophie MEYNIEUX
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13018 : Static fine should be charged only once (2.46 KB, patch)
2014-10-01 13:05 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 13018 : Static fine should be charged only once (2.51 KB, patch)
2014-10-14 11:34 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 13018 : Static fine should be charged only once (2.73 KB, patch)
2014-10-16 15:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2014-10-01 09:53:47 UTC
Once a borrower is charged for overdues, staticfine.pl execution should not add a new fine each time.
Comment 1 Sophie MEYNIEUX 2014-10-01 13:05:05 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-14 11:34:40 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-16 15:29:06 UTC
Created attachment 32425 [details] [review]
[PASSED QA] Bug 13018 : Static fine should be charged only once

Test plan (see Bug 6858 for using staticfine.pl) :

For a user (of a given category and library) with several overdues, launch the script :

staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY

Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today.

One day later, re-execute the script with the same parameters and check that the fine has not been charged twice.

Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Without the patch, the fine will be applied every time the script is run.
With the patch the fine will only be applied once.
Passes tests and QA script.
Comment 4 Tomás Cohen Arazi 2014-11-11 12:58:14 UTC
Patch pushed to master.

Thanks Sophie!