Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds.
Summary: "Today's checkouts" sort improperly because issuedate lacks seconds.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on: 11703
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-30 12:54 UTC by Olli-Antti Kivilahti
Modified: 2015-12-03 22:03 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds. (1.42 KB, patch)
2014-10-30 12:57 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review
[Signed-off] Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds. (1.61 KB, patch)
2014-10-31 05:28 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds. (1.58 KB, patch)
2014-10-31 15:26 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2014-10-30 12:54:02 UTC
TO REPLICATE:

Prepare a bunch of Items (6+) for checking out, or have a set of barcodes ready for copy-pasting.
Check-out those items quickly within one minute and observe that the sorting order is not always from the first checkout to the last.

This is because the issuedate doesn't have seconds defined.

AFTER THIS

The bunch of Items is sorted properly.
Comment 1 Olli-Antti Kivilahti 2014-10-30 12:57:52 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-10-31 05:28:53 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2014-10-31 15:26:35 UTC
Created attachment 33082 [details] [review]
[PASSED QA] Bug 13168 - "Today's checkouts" sort improperly because issuedate lacks seconds.

TO REPLICATE:

Prepare a bunch of Items (6+) for checking out, or have a set of barcodes ready for copy-pasting.
Check-out those items quickly within one minute and observe that the sorting order is not always from the first checkout to the last.

This is because the issuedate doesn't have seconds defined.

AFTER THIS

The bunch of Items is sorted properly.

Tiny patch, works as expected. Passed QA script.
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Fred P 2014-11-04 18:02:02 UTC
I like it, but shouldn't the order be newest checkout to oldest? That way the circulation staff sees the most recent item at the top of the list.
Comment 5 Fred P 2014-11-04 19:48:41 UTC
Excuse me, I see that is covered in bug #13020.
Comment 6 Tomás Cohen Arazi 2014-11-17 00:26:49 UTC
Patch pushed to master.

Thanks Owen!
Comment 7 Tomás Cohen Arazi 2014-11-17 00:29:55 UTC
I mean, Olli :-D
Comment 8 Olli-Antti Kivilahti 2014-11-26 12:29:43 UTC
I aim to please!

IMHO the biggest challenge is not to write the code. Thie biggest challenge is to find all the awesome people who make the final push!
Thank you all who made this happen!
Comment 9 Mason James 2015-01-19 14:45:53 UTC
(In reply to Tomás Cohen Arazi from comment #6)
> Patch pushed to master.
> 
> Thanks Owen!

Pushed to 3.16.x, will be in 3.16.7