Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on
Summary: Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsFo...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 10860 13179
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-31 18:04 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on (3.92 KB, patch)
2014-10-31 18:49 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on (3.95 KB, patch)
2014-10-31 20:29 UTC, Nick Clemens
Details | Diff | Splinter Review
[PASSED QA] Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on (4.09 KB, patch)
2014-10-31 20:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-31 18:04:43 UTC
Because of the way the template logic works, having OnSiteCheckouts off but OnSiteCheckoutsForce on creates problems with what controls and information are displayed when a patron is blocked from checking out.
Comment 1 Owen Leonard 2014-10-31 18:49:14 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2014-10-31 20:29:10 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-31 20:55:49 UTC
Created attachment 33114 [details] [review]
[PASSED QA] Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on

Checks in the circulation template for on-site checkouts preferences did
not take into account the possibility that someone might have
accidentally turned OnSiteCheckouts off but left OnSiteCheckoutsForce
turned on. This patch amends the template logic so that it works
correctly for various combinations of settings.

To test, apply the patch and test the following combinations of
circumstances.

Testing using both a patron who is blocked (expired, restricted, etc)
and a patron who is not blocked, test with...

1. OnSiteCheckouts is on, OnSiteCheckoutsForce is on
2. OnSiteCheckouts is off, OnSiteCheckoutsForce is on
3. OnSiteCheckouts is off, OnSiteCheckoutsForce is off
4. OnSiteCheckouts is on, OnSiteCheckoutsForce is off

Confirm that the checkout form is shown or not shown correctly according
to the preferences you have set. Confirm that the "Only on-site
checkouts are allowed" message is only shown in case #1.

Note: This patch includes whitespace changes, so please diff
accordingly.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested on top of 10860 and 13179.
Works as described, adding more checks in the templates.
Comment 4 Tomás Cohen Arazi 2014-11-03 15:30:08 UTC
Patch pushed to master.

Thanks Owen!