Bug 13273 - Additem.pl barcode tag editor useless with autoBarcode disabled
Summary: Additem.pl barcode tag editor useless with autoBarcode disabled
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-17 18:43 UTC by Christopher Brannon
Modified: 2019-11-02 21:53 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2014-11-17 18:43:59 UTC
If autoBarcode is disabled in preferences, a useless tag editor remains next to the barcode field in additem.pl.  It would be preferable if this button was hidden when this preference is disabled.

Just a cosmetic and workflow (tabbing) issue.

Christopher
Comment 1 Marcel de Rooy 2014-11-17 19:00:58 UTC
Work in progress on bug 10480 will make this easier to fix.
Comment 2 Katrin Fischer 2014-11-17 20:53:09 UTC
Hi Christopher, I think it would disappear if the link to the plugin was removed from the framework.
Comment 3 Marcel de Rooy 2014-11-17 21:14:49 UTC
If you do not use a plugin, you can of course always remove it as Katrin says.

In the meantime I tested my plugin proposal: If a plugin does not have a popup, I will set tabindex=-1 for the buttonDot anchor (with the tag editor image). So your tab does not reach it.

To make it even more visual, I would like to do something with the color or the image to make a distinction between a plugin with a popup and a plugin without a popup (that still contains some action linked to Blur, Focus, etc.) The image should still signal the user that this field has something extra..
Comment 4 Katrin Fischer 2014-11-17 21:21:38 UTC
I like the idea of using a bit more obvious icons :)
Comment 5 Christopher Brannon 2014-11-17 22:28:53 UTC
(In reply to Katrin Fischer from comment #2)
> Hi Christopher, I think it would disappear if the link to the plugin was
> removed from the framework.

That did the trick.  I prefer the method being worked on in the fix, but for now, that easily takes the issue out of the way.  Thanks!

Christopher