To reproduce: - Do a syspref search, for example 'facet'. => FAIL: Some highlighted occurences of 'facet' have styling problems, check the attached screenshots. Note: Firefox seems to render it properly, this is just in Chrome.
Created attachment 34075 [details] Before the patch
Created attachment 34076 [details] After the patch
Created attachment 34077 [details] [review] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix into a <span>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct - Sign off :-D Regards
Created attachment 34092 [details] [review] Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct
Created attachment 34093 [details] [review] [SIGNED OFF] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 34144 [details] [review] [PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master. Thanks Owen!