Bug 8007 DB changes forgot de-DE DISCHARGE message, prove xt/sample_notices.t fails
Created attachment 38760 [details] [review] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome.
If a German patch is provided, please reset assignee :) I will sign.
This works, but I rather a German counter patch. :)
Created attachment 38761 [details] [review] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :)
Created attachment 38765 [details] [review] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors
Created attachment 38766 [details] [review] [SIGNED_OFF] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version
First patch obsoleted
Comment on attachment 38761 [details] [review] Bug 14119: Missing de-DE DISCHARGE message It looks like the second patch requires the first. Unchecking 'obsolete' for a clean apply.
Created attachment 38770 [details] [review] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Required for a clean install of German patch.
Created attachment 38771 [details] [review] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version Signed-off-by: Mark Tompsett <mtompset@hotmail.com> German version. YAY!
Created attachment 38784 [details] [review] [PASSED QA] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 38785 [details] [review] [PASSED QA] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Good job Bernardo and Marc!