Dobrica reported on bug 12412: This bug will break Koha installation if there is no enable_plugins in koha-conf.xml with following error: Can't call method "GetPlugins" on an undefined value at /srv/koha_ffzg/tools/stage-marc-import.pl line 206, <DATA> line 603. This is not ideal, since it will break old installations. Problem is line: Koha::Plugins->new()->GetPlugins('to_marc'); where Koha::Plugins->new() will return undef is plugins are not enabled. It seems we also have same syntax in plugins/plugins-home.pl so it should probably be fixed also. -- It's a little bit worse: plugins had to be enabled. Even adding <enable_plugins>0</enable_plugins> to koha-conf.xml won't help.
Created attachment 38853 [details] [review] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas
Created attachment 38873 [details] [review] [SIGNED.OFF] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors
Created attachment 38887 [details] [review] [PASSED QA] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patch pushed to master.