On the order form there is a checkbox next to the fund list labelled 'show all'. I think the description is not very clear here as librares are asking about the effect of the checkbox. Suggestion: relabel it to say: show inactive.
Created attachment 39473 [details] [review] Bug 14163: Acq order form: rename 'Show all' to 'Show inactive' On the order form there is a checkbox next to the fund list labelled 'show all'. Checking the checkbox will result in the inactive funds showing in the pull down list as well. The patch renames the label to 'Show inactive' to make the purpose more clear. To test: - Create a new order - Verify the label has changed as described above - Decide if the change makes sense
Created attachment 39501 [details] [review] Bug 14163: Acq order form: rename 'Show all' to 'Show inactive' On the order form there is a checkbox next to the fund list labelled 'show all'. Checking the checkbox will result in the inactive funds showing in the pull down list as well. The patch renames the label to 'Show inactive' to make the purpose more clear. To test: - Create a new order - Verify the label has changed as described above - Decide if the change makes sense Signed-off-by: tadeasm <tadeas.moravec@gmail.com>
Katrin, 'Show all' is used at several places. If we change one, I think we should change of all them in one go. At least: acqui/addorderiso2709.tt acqui/parcels.tt
Created attachment 39709 [details] [review] Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected.
(In reply to Jonathan Druart from comment #3) > Katrin, > 'Show all' is used at several places. > If we change one, I think we should change of all them in one go. > > At least: > acqui/addorderiso2709.tt > acqui/parcels.tt Hi Jonathan, thx for failing ;) Hope the follow-up covers them all now.
Created attachment 40310 [details] [review] Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Simple string change, no errors.
Created attachment 40311 [details] [review] Bug 14163: Acq order form: rename 'Show all' to 'Show inactive' On the order form there is a checkbox next to the fund list labelled 'show all'. Checking the checkbox will result in the inactive funds showing in the pull down list as well. The patch renames the label to 'Show inactive' to make the purpose more clear. To test: - Create a new order - Verify the label has changed as described above - Decide if the change makes sense Signed-off-by: tadeasm <tadeas.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Created attachment 40312 [details] [review] Bug 14163: Acq - receive shipment and order from staged: rename 'Show all' to 'Show inactive' 'Show all' in acquisition makes the inactive funds in the fund list box visible. This patch changes the text to 'Show inactive' to be more clear about the functionality. Patch changes 2 pages. To test: 1) Order from staged file - make sure you have uploaded a few records via the tools - create a new order using the 'From a staged file' option - select a file to order from - 'Add orders' - Verify the 'Select to import' tab now displayed the text 'Show inactive funds' and that it works as expected - Switch to the 'Default accounting details' tab - Verify the text there is also changed to 'Show inactive' and works like expected. 2) Receive shipment - receive a new shipment for a vendor with unreceived orders - Verify the label next to the fund list has changed to 'Show inactive' and works as expected. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Simple string change, no errors. Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Patches pushed to master. Thanks Katrina!
Pushed to 3.20.x will be in 3.20.2