There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". Some sort of break needed between the two messages.
This may be version specific. I could not replicate this in 3.21. Christopher
Created attachment 41431 [details] [review] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines
Created attachment 41432 [details] [review] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines
Created attachment 41433 [details] [review] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines
Created attachment 41434 [details] [review] [SIGNED-OFF] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum@nekls.org>
Created attachment 41458 [details] [review] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 41648 [details] [review] Bug 14661 - space needed in added to staff side cart message, if items added are already in cart There is a missing space in the "added to cart" message on the staff side, when you are adding 2 or more items to the cart, where 1+ is already in the cart and 1+ is not in the cart. I verified that this is not an issue in the OPAC cart function. Test: 1. Search for records in your system. 2. In search results, select the first two records and choose Add to Cart. 3. Message returned, "2 item(s) added to your cart", as expected. 4. Keep those 2 records selected, and select 2 additional records (so 4 total records selected), and choose Add to Cart again. 5. Message returned, "2 item(s) added to your cart2 already in your cart". 6. Apply this patch 7. Repeat steps 1 through 4 8. Note the two phrases are on separate lines Signed-off-by: Heather Braum <hbraum@nekls.org> Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I confirm the bug on master.
Patch pushed to master. Thanks Kyle!