Bug 14783 - Allow patrons to change pickup location for non-waiting holds
Summary: Allow patrons to change pickup location for non-waiting holds
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Björn Nylén
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-03 18:43 UTC by Kyle M Hall
Modified: 2021-10-21 21:42 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Allow users to change pickup location for hold from the opac (8.01 KB, patch)
2021-03-12 13:16 UTC, Björn Nylén
Details | Diff | Splinter Review
Allow users to change pickup location for hold from the opac (7.69 KB, patch)
2021-03-15 15:17 UTC, Björn Nylén
Details | Diff | Splinter Review
Bug 14783: Change pickup location from opac. (7.78 KB, patch)
2021-07-26 17:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 14783: (follow-up) Move pickup library form into modal (10.79 KB, patch)
2021-07-28 19:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 14783: Change pickup location from opac. (7.84 KB, patch)
2021-08-10 16:34 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review
Bug 14783: (follow-up) Move pickup library form into modal (10.86 KB, patch)
2021-08-10 16:34 UTC, sandboxes@biblibre.com
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-09-03 18:43:12 UTC
This enhancement would allow patrons to change the pickup location for any hold that is not already waiting ( e.g. it would be allowable for in transit holds ).

For non-found holds the feature will not change much behavior. For in-transit holds the feature would trigger a completion of the current transfer and generate a new transfer from the previous target library to the new target library.

The feature would be controlled via a system preference.
Comment 1 NancyK. 2016-12-07 21:07:21 UTC
My staff is asking for this option.  We have a branch closed for remodeling and it would have been great to allow patrons to redirect their unfilled holds to another location.  Redirecting after it is in-transit isn't as important.
NancyK
Comment 2 Daniel Gaghan 2018-12-27 19:55:49 UTC
Just migrated over to Koha and our staff and users are asking for this option too.
Comment 3 Timothy Alexis Vass 2021-02-12 14:24:46 UTC
We are trying to understand how it makes sense to allow changing location for in transit holds. Could someone comment on this?
Comment 4 Katrin Fischer 2021-02-12 14:45:08 UTC
Hm it might be nice to control 'not pulled yet' and 'in transit' separately. But I guess patrons could realize they made a wrong setting after placing the hold and it could be useful then?
Comment 5 Timothy Alexis Vass 2021-02-12 15:57:30 UTC
I think we could have a multiple select in the system preference to set which statuses to allow it for.

Something like:
OpacAllowPickupLocationChange
Enable allowing patrons to change pickup location for these statuses: <multiple select element>

Then each library can decide which statuses to allow it for at the same time as activating it.
Comment 6 Timothy Alexis Vass 2021-03-02 13:35:58 UTC
Should it be possible to change pick up location for suspended holds?
Comment 7 Katrin Fischer 2021-03-04 09:35:54 UTC
(In reply to Timothy Alexis Vass from comment #6)
> Should it be possible to change pick up location for suspended holds?

I'd say so. You suspend them before they have been filled, so this should be ok.
Comment 8 Björn Nylén 2021-03-12 13:16:13 UTC
Created attachment 118189 [details] [review]
Allow users to change pickup location for hold from the opac
Comment 9 Björn Nylén 2021-03-12 13:21:25 UTC
Timothy gave this bug to me so here's a patch. :)


Bug 14783: Change pickup location from opac.
    
    This patch allows users to change the  pickup location for their holds from
    the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage
    a hold can be changed.
    
    To test:
    1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended)
    2. No pickup locations for any hold should be able to be changed.
    3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that
    only the corresponding holds can be changed from the opac. Check eg in the staff client that
    pickup location has changed.
    4. The available pickup locations should respect any transfer restrictions. (Same as the
    holds list for a biblio in staff client)
    5. For an in-transit hold: Check in the item at the original pickup location.
    6. Note that it will be redirected to the new location.
    
    Sponsored-by: Lunds Universitetsbibliotek
Comment 10 Björn Nylén 2021-03-15 15:17:47 UTC
Created attachment 118241 [details] [review]
Allow users to change pickup location for hold from the opac

Doh! Updated patch! Previous patch included some bits that wasn't supposed to be there. Same test case.
Comment 11 Owen Leonard 2021-07-26 17:27:00 UTC
Created attachment 123199 [details] [review]
Bug 14783: Change pickup location from opac.

This patch allows users to change the  pickup location for their holds
from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what
stage a hold can be changed.

To test:
1. Set up holds with diffrent statuses for a patron (pending, waiting,
   in transit, suspended)
2. No pickup locations for any hold should be able to be changed.
3. Turn on and off the different options under
   OPACAllowUserToChangeBranch. Make sure that only the corresponding
   holds can be changed from the opac. Check eg in the staff client that
   pickup location has changed.
4. The available pickup locations should respect any transfer
   restrictions. (Same as the
   holds list for a biblio in staff client)
5. For an in-transit hold: Check in the item at the original pickup
   location.
6. Note that it will be redirected to the new location.

Sponsored-by: Lunds Universitetsbibliotek

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Owen Leonard 2021-07-28 19:30:35 UTC
Created attachment 123271 [details] [review]
Bug 14783: (follow-up) Move pickup library form into modal

This patch attemps to simplify the list of holds by moving the form for
changing a hold's pickup library into a modal dialog.

This patch also makes minor tweaks to the CSS for the "X" close button
shown in modal in windows. Instances where modal markup used "x" have
been updated to use the Bootstrap 4 standard "&times;"

To test, apply the patch and rebuild the OPAC
SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Turn on the OPACAllowUserToChangeBranch system preference.
- Log in to the OPAC as a user with holds.
- In the view of your holds, confirm that each hold which can be
  modified shows a "Change" link.
- Clicking the link should show a modal window with the title of the
  item on hold shown in the header.
- Confirm that changing the pickup location works correctly.
Comment 13 sandboxes@biblibre.com 2021-08-10 16:34:15 UTC
Created attachment 123708 [details] [review]
Bug 14783: Change pickup location from opac.

This patch allows users to change the  pickup location for their holds
from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what
stage a hold can be changed.

To test:
1. Set up holds with diffrent statuses for a patron (pending, waiting,
   in transit, suspended)
2. No pickup locations for any hold should be able to be changed.
3. Turn on and off the different options under
   OPACAllowUserToChangeBranch. Make sure that only the corresponding
   holds can be changed from the opac. Check eg in the staff client that
   pickup location has changed.
4. The available pickup locations should respect any transfer
   restrictions. (Same as the
   holds list for a biblio in staff client)
5. For an in-transit hold: Check in the item at the original pickup
   location.
6. Note that it will be redirected to the new location.

Sponsored-by: Lunds Universitetsbibliotek

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 14 sandboxes@biblibre.com 2021-08-10 16:34:18 UTC
Created attachment 123709 [details] [review]
Bug 14783: (follow-up) Move pickup library form into modal

This patch attemps to simplify the list of holds by moving the form for
changing a hold's pickup library into a modal dialog.

This patch also makes minor tweaks to the CSS for the "X" close button
shown in modal in windows. Instances where modal markup used "x" have
been updated to use the Bootstrap 4 standard "&times;"

To test, apply the patch and rebuild the OPAC
SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Turn on the OPACAllowUserToChangeBranch system preference.
- Log in to the OPAC as a user with holds.
- In the view of your holds, confirm that each hold which can be
  modified shows a "Change" link.
- Clicking the link should show a modal window with the title of the
  item on hold shown in the header.
- Confirm that changing the pickup location works correctly.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 15 Katrin Fischer 2021-10-21 21:42:50 UTC
Took a first look here and I think we will need unit tests for the new sub in Holds.pm: can_change_branch_opac